1418488 - drop EmailCampaign, EmailContact, and related models

Status: RESOLVED FIXED

(Socorro :: Database, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We use sqlalchemy as an ORM in the Socorro apps. The models are defined in socorro/external/postgresql/models.py.

In that file, there are several models:

1. EmailCampign
2. EmailContact
3. EmailCampaignsContact

EmailCampaign has bugs preventing sqlalchemy ORM from using the models. Further, these three models aren't used anywhere and have no tests.

This bug covers creating a migration to remove the database tables and removing the model code.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I can't use the ORM until this gets resolved, so I'm making it a P1 and grabbing it to do asap.

One thing I don't know offhand if there's data in these tables in production that we need to keep. I'll look into that.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4214: fixes bug 1418488 - drop EmailCampaign, EmailContact, and EmailCampaignsContact

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

After that PR lands, we need to run alembic migrations on the admin nodes.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/26a4c30e858db66d07af9c5b133ab2530e20a532
fixes bug 1418488 - drop EmailCampaign, EmailContact, and EmailCampaignsContact

Socorro no longer uses these tables, so time to drop them.

https://github.com/mozilla-services/socorro/commit/44510de6a91a4ffabbdb518e00a958c7b885416f
Merge pull request #4214 from willkg/1418488-drop-email

fixes bug 1418488 - drop EmailCampaign, EmailContact, and EmailCampaignsContact

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I updated the -stage admin node and then checked the email* tables to see if they had any data. They didn't:

breakpad=> select count(*) from email_campaigns;
 count 
-------
     0
(1 row)

breakpad=> select count(*) from email_contacts;
 count 
-------
     0
(1 row)

Then I ran the migrations:

(socorro-virtualenv)[root@xxx application]# env sqlalchemy.url=postgresql://xxx:xxx@xxx/breakpad alembic -c /etc/socorro/alembic.ini upgrade heads
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade 77856f165be7 -> f35c26426066, bug 1418488 drop emailcampaign
(socorro-virtualenv)[root@xxx application]# env sqlalchemy.url=postgresql://xxx:xxx@xxx/breakpad alembic -c /etc/socorro/alembic.ini upgrade history
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
ERROR [alembic.util.messaging] Can't locate revision identified by 'history'
  FAILED: Can't locate revision identified by 'history'
(socorro-virtualenv)[root@xxx application]# env sqlalchemy.url=postgresql://xxx:xxx@xxx/breakpad alembic -c /etc/socorro/alembic.ini current
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
f35c26426066 (head)

I'll do -prod after we deploy to -prod.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I checked -prod and it also has no data, so we don't need to dump anything.

After we deploy to -prod, I'll run the migrations.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ran the migration in -prod:

(socorro-virtualenv)[root@xxx application]# env sqlalchemy.url=postgresql://xxx:xxx@xxx/breakpad alembic -c /etc/socorro/alembic.ini upgrade heads
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade 77856f165be7 -> f35c26426066, bug 1418488 drop emailcampaign
(socorro-virtualenv)[root@xxx application]# 

All done!