1418507 - Include more directories in Android Studio's file search

Status: NEW

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Jan Henning [:JanH]]

Ctrl+Shift+N is a quick way of opening a file in Android Studio, but at the moment its search only returns files inside the mobile and toolkit directories.

When working on native code, it would be nice if those files would be available as well to avoid having to manually find them somewhere within the mozilla-central directory structure.

At the very least this would mean the files under /widget/android, but other parts of Gecko (except for /browser I guess) would be interesting as well.

Ideally we'd be able to detect artifact mode and only include those additional directories when artifact mode is not enabled, so people working on the front-end only wouldn't be bothered by all the additional native code files turning up in the search results.

Comment 1

[Nick Alexander :nalexander [he/him]]

Sketch of how I think this might work:

- add Gradle project mobile/android/geckoview/native_code
- add :native_code project in /settings.gradle conditionally, only if COMPILE_ENVIRONMENT
- add C++ directories to :native_code project, like omnijar
- don't depend on :native_code project directly
- wire up |mach build binaries| and possibly some additional file copying like existing `buildOmnijars` task
- but only when we're building "local" and "withGeckoBinaries"

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #1)
> Sketch of how I think this might work:
> 
> - add Gradle project mobile/android/geckoview/native_code
> - add :native_code project in /settings.gradle conditionally, only if
> COMPILE_ENVIRONMENT
> - add C++ directories to :native_code project, like omnijar
> - don't depend on :native_code project directly
> - wire up |mach build binaries| and possibly some additional file copying
> like existing `buildOmnijars` task
> - but only when we're building "local" and "withGeckoBinaries"

Oh!  That last depends on Bug 1411654, which makes this approach sensible.