Closed Bug 1418635 Opened 3 years ago Closed 3 years ago

Increase timeouts and chunks for some test suites for the Windows coverage build

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 1 obsolete file)

Tests in an instrumented build are slower, so we need to increase timeouts or chunks (similar to what we have done for linux64-ccov).
Attached patch Patch (obsolete) — Splinter Review
This makes chunks and timeouts on the Windows coverage build closer to what we have defined for the Linux coverage build. We can improve them over time with some experience on how they behave in the field.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8929738 - Flags: review?(jmaher)
Comment on attachment 8929738 [details] [diff] [review]
Patch

Review of attachment 8929738 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/test/mochitest.yml
@@ +38,5 @@
>              android.*: 20
>              linux.*/debug: 16
>              linux64-asan/opt: 10
>              linux64-.*cov/opt: 10
> +            windows10-64-ccov/debug: 8

why not make this 10 chunks like jsdcov and ccov on linux?
Attachment #8929738 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4bf28b7ada6
Increase timeout and chunks for some test suites on Windows coverage builds. r=jmaher
Attached patch PatchSplinter Review
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #2)
> Comment on attachment 8929738 [details] [diff] [review]
> Patch
> 
> Review of attachment 8929738 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: taskcluster/ci/test/mochitest.yml
> @@ +38,5 @@
> >              android.*: 20
> >              linux.*/debug: 16
> >              linux64-asan/opt: 10
> >              linux64-.*cov/opt: 10
> > +            windows10-64-ccov/debug: 8
> 
> why not make this 10 chunks like jsdcov and ccov on linux?

Done!
Attachment #8929738 - Attachment is obsolete: true
Attachment #8930026 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f4bf28b7ada6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.