Closed Bug 1418944 Opened 4 years ago Closed 2 years ago

Quote CC/CXX variables passed to nspr

Categories

(NSS :: Build, enhancement, P1)

3.44
enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hanno, Assigned: hanno)

References

Details

Attachments

(1 file)

The Makefile doesn't put quotes around the assignment of CC variables when calling the nspr configure (if building with nss_build_all).

This breaks e.g. if someone tries to pass flags in the CC (hacky, but sometimes makes things easier) or if there are spaces in the path to the compiler. In any case, quoting makes things cleaner and shouldn't have any downsides.

Patch attached, please apply.
Comment on attachment 8930028 [details] [diff] [review]
nss-escape-cc-cxx-vars.diff

Review of attachment 8930028 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but I recommend building with build.sh.
Attachment #8930028 - Flags: review+

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hanno, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(hanno)

I'm not sure what's expected from me here.

I can't commit it, as I'm not a Mozilla dev.

The patch still makes sense and would make it easier to work with the (old) buildsystem in some situations. If anyone could commit it that'd be great.

Flags: needinfo?(hanno)
Assignee: nobody → hanno
Status: NEW → ASSIGNED
Keywords: checkin-needed
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: 3.34 → 3.44
Target Milestone: --- → 3.44
Depends on: 1561510
You need to log in before you can comment on or make changes to this bug.