1418944 - Quote CC/CXX variables passed to nspr

Status: RESOLVED FIXED

(NSS :: Build, enhancement, P1)

Description

[Hanno Boeck]

Attachment: nss-escape-cc-cxx-vars.diff

The Makefile doesn't put quotes around the assignment of CC variables when calling the nspr configure (if building with nss_build_all).

This breaks e.g. if someone tries to pass flags in the CC (hacky, but sometimes makes things easier) or if there are spaces in the path to the compiler. In any case, quoting makes things cleaner and shouldn't have any downsides.

Patch attached, please apply.

Comment 1

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8930028 [details] [diff] [review]
nss-escape-cc-cxx-vars.diff

Review of attachment 8930028 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but I recommend building with build.sh.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hanno, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Hanno Boeck]

I'm not sure what's expected from me here.

I can't commit it, as I'm not a Mozilla dev.

The patch still makes sense and would make it easier to work with the (old) buildsystem in some situations. If anyone could commit it that'd be great.

Comment 4

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/c4aed23253ca4e30fa9650bed02a00d1053a79ea