1418963 - Expose -moz-os-version and related media queries in userChrome.css

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Alex Vallat]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171115114231

Steps to reproduce:

1396066 made many media features chrome-only, but support for them has also been removed from userChrome.css

Not being able to define styles per-os using these queries can be quite limiting.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I wonder if it'd make sense to just enable all chrome-only features in user sheets too. WDYT Cameron?

Comment 2

[Boris Zbarsky [:bzbarsky]]

So the chrome-only but not "ua-only" features, right?

That would probably be ok, I suspect...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #2)
> So the chrome-only but not "ua-only" features, right?

Right, we wouldn't expose stuff like the anon box selectors and all those, only ua-only media-queries and properties.

Comment 4

[Cameron McCormack (:heycam)]

Sounds OK to me.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Okie dookie.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1418963: Enable chrome-only CSS features in user stylesheets.

Review commit: https://reviewboard.mozilla.org/r/201562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201562/

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Sorry for the drive-by cleanup, couldn't resist.

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8930397 [details]
Bug 1418963: Enable chrome-only CSS features in user stylesheets.

https://reviewboard.mozilla.org/r/201562/#review206800

::: servo/components/style/properties/properties.mako.rs:1359
(Diff revision 1)
>      }
>  }
>  
>  /// Parsing Context for PropertyId.
>  pub struct PropertyParserContext {
>      /// Whether the property is parsed in a chrome:// stylesheet.

Update this comment?

Comment 9

[Cameron McCormack (:heycam)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #7)
> Sorry for the drive-by cleanup, couldn't resist.

Heh, I didn't mind this time. :-)

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8930397 [details]
Bug 1418963: Enable chrome-only CSS features in user stylesheets.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201562/diff/1-2/

Comment 11

[Emilio Cobos Álvarez (:emilio)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #10)
> Comment on attachment 8930397 [details]
> Bug 1418963: Enable chrome-only CSS features in user stylesheets.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/201562/diff/1-2/

Now with a (very simple) test.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8930397 [details]
Bug 1418963: Enable chrome-only CSS features in user stylesheets.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201562/diff/2-3/

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Servo bits: https://hg.mozilla.org/integration/autoland/rev/44e456dda205 / https://github.com/servo/servo/pull/19315

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6b21b2945d
Enable chrome-only CSS features in user stylesheets. r=heycam

Comment 15

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ed6b21b2945d

Comment 17

[Aris]

This issue is still present in Firefox 58. Can somebody uplift the fix to Fx58?

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8930397 [details]
Bug 1418963: Enable chrome-only CSS features in user stylesheets.

I'm not sure it'll be accepted (it's in release already), but worth a try I guess.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1396066 
[User impact if declined]: User stylesheets being a bit less powerful.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none, patch here should apply cleanly to m-r.
[Is the change risky?]: not risky
[Why is the change risky/not risky?]: this change has been in nightly for a long time already.
[String changes made/needed]: none

Comment 19

[Julien Cristau [:jcristau]]

Sorry, we're shipping tomorrow, I don't think this qualifies for delaying the release, or for inclusion in a dot release.

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8930397 [details]
Bug 1418963: Enable chrome-only CSS features in user stylesheets.

Yup, as expected, but it was worth a shot :).

Thanks Julien!

Comment 21

[Aris]

What about uplifting for a 58.0.1 release (next week or later)?