1419247 - Allow Stringify() to support nsSize.

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Chih-Hsuan Kuo [:tommykuo]]

Allow us to use Stringify() with nsSize.

Comment 1

[Chih-Hsuan Kuo [:tommykuo]]

Attachment: Bug 1419247 - Allow Stringify() to support nsSize.

Review commit: https://reviewboard.mozilla.org/r/201470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201470/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8930331 [details]
Bug 1419247 - Allow Stringify() to support nsSize.

https://reviewboard.mozilla.org/r/201470/#review206616

Comment 3

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8930331 [details]
Bug 1419247 - Allow Stringify() to support nsSize.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201470/diff/1-2/

Comment 4

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8930331 [details]
Bug 1419247 - Allow Stringify() to support nsSize.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201470/diff/2-3/

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8930331 [details]
Bug 1419247 - Allow Stringify() to support nsSize.

https://reviewboard.mozilla.org/r/201470/#review206622

::: gfx/layers/LayersLogging.cpp:113
(Diff revision 2)
> +  aStream << pfx;
> +  aStream << nsPrintfCString(
> +    "(w=%d, h=%d)",
> +    sz.width, sz.height).get();
> +  aStream << sfx;
> +}

Nit: A blank line here, please.

Comment 6

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8930331 [details]
Bug 1419247 - Allow Stringify() to support nsSize.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201470/diff/3-4/

Comment 7

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8930331 [details]
Bug 1419247 - Allow Stringify() to support nsSize.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201470/diff/4-5/

Comment 8

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8930331 [details]
Bug 1419247 - Allow Stringify() to support nsSize.

https://reviewboard.mozilla.org/r/201470/#review206628

carry r+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/476e4e86e9df
Allow Stringify() to support nsSize. r=mtseng

Comment 10

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/476e4e86e9df