1419249 - [Fennec][HLS] Audio only playback will not work correctly after seek.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P2)

Description

[Kilik Kuo [:kikuo] (inactive)]

https://www2.nhk.or.jp/gogaku/mygogaku/streaming/?spid=00000904

For this audio only content, MFR keeps calling internal seek.

Comment 1

[James Cheng[:JamesCheng]]

We calculated the wrong start time with Audio-only content...

It makes us set the start time to Long.MIN_VALUE in this case.

I should fix it.

Comment 2

[James Cheng[:JamesCheng]]

Attachment: Bug 1419249 - Fix the wrong logic calculating starttime of the first sample.

Review commit: https://reviewboard.mozilla.org/r/201950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201950/

Comment 3

[James Cheng[:JamesCheng]]

Hi John,

Does this bug related to webcompat?

I search "nhk" and I cannot get any opened bug from

https://github.com/webcompat/web-bugs/issues

BTW,
Should this bug be prioritized?

Thank you.

Comment 4

[John Lin [:jhlin][:jolin]]

(In reply to James Cheng[:JamesCheng] from comment #3)
> Hi John,
> 
> Does this bug related to webcompat?
> 
> I search "nhk" and I cannot get any opened bug from
> 
> https://github.com/webcompat/web-bugs/issues
> 
> BTW,
> Should this bug be prioritized?
> 
> Thank you.

See https://github.com/webcompat/web-bugs/issues/13586. It's closed since this one is filed.

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8930847 [details]
Bug 1419249 - Fix the wrong logic calculating starttime of the first sample.

https://reviewboard.mozilla.org/r/201950/#review207362

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java:727
(Diff revision 1)
>              }
>              if (DEBUG) {
>                  Log.d(LOGTAG, "seeking  : " + positionUs / 1000 +
>                                " (ms); startTime : " + startTime / 1000 + " (ms)");
>              }
> -            assertTrue(startTime != Long.MAX_VALUE);
> +            assertTrue(startTime != Long.MAX_VALUE || startTime != Long.MIN_VALUE);

Shouldn't it be 
assertTrue(startTime != Long.MAX_VALUE && startTime != Long.MIN_VALUE) ?

Comment 6

[James Cheng[:JamesCheng]]

Comment on attachment 8930847 [details]
Bug 1419249 - Fix the wrong logic calculating starttime of the first sample.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201950/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e75818a3342
Fix the wrong logic calculating starttime of the first sample. r=kikuo

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4e75818a3342

Comment 9

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 59 (2017-12-08).
Device: HTC Desire 820 (Android 6.0.1)