Closed Bug 1419249 Opened 2 years ago Closed 2 years ago

[Fennec][HLS] Audio only playback will not work correctly after seek.

Categories

(Firefox for Android :: Audio/Video, defect, P2)

Product:
Firefox for Android
Component:
Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- verified

People

(Reporter: kikuo, Assigned: JamesCheng)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1419249 - Fix the wrong logic calculating starttime of the first sample.
59 bytes, text/x-review-board-request
kikuo
: review+
Details 
https://www2.nhk.or.jp/gogaku/mygogaku/streaming/?spid=00000904

For this audio only content, MFR keeps calling internal seek.
Summary: [Fennec][HLS] Audio only playback will work correctly after seek. → [Fennec][HLS] Audio only playback will work not correctly after seek.
Summary: [Fennec][HLS] Audio only playback will work not correctly after seek. → [Fennec][HLS] Audio only playback will not work correctly after seek.
We calculated the wrong start time with Audio-only content...

It makes us set the start time to Long.MIN_VALUE in this case.

I should fix it.
Assignee: nobody → jacheng
Hi John,

Does this bug related to webcompat?

I search "nhk" and I cannot get any opened bug from

https://github.com/webcompat/web-bugs/issues

BTW,
Should this bug be prioritized?

Thank you.
Flags: needinfo?(jolin)
Attachment #8930847 - Flags: review?(kikuo)
Priority: -- → P2
(In reply to James Cheng[:JamesCheng] from comment #3)
> Hi John,
> 
> Does this bug related to webcompat?
> 
> I search "nhk" and I cannot get any opened bug from
> 
> https://github.com/webcompat/web-bugs/issues
> 
> BTW,
> Should this bug be prioritized?
> 
> Thank you.

See https://github.com/webcompat/web-bugs/issues/13586. It's closed since this one is filed.
Flags: needinfo?(jolin)
Comment on attachment 8930847 [details]
Bug 1419249 - Fix the wrong logic calculating starttime of the first sample.

https://reviewboard.mozilla.org/r/201950/#review207362

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java:727
(Diff revision 1)
>              }
>              if (DEBUG) {
>                  Log.d(LOGTAG, "seeking  : " + positionUs / 1000 +
>                                " (ms); startTime : " + startTime / 1000 + " (ms)");
>              }
> -            assertTrue(startTime != Long.MAX_VALUE);
> +            assertTrue(startTime != Long.MAX_VALUE || startTime != Long.MIN_VALUE);

Shouldn't it be 
assertTrue(startTime != Long.MAX_VALUE && startTime != Long.MIN_VALUE) ?
Attachment #8930847 - Flags: review?(kikuo) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e75818a3342
Fix the wrong logic calculating starttime of the first sample. r=kikuo
https://hg.mozilla.org/mozilla-central/rev/4e75818a3342
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Verified as fixed on Nightly 59 (2017-12-08).
Device: HTC Desire 820 (Android 6.0.1)
status-firefox59: fixed → verified
You need to log in before you can comment on or make changes to this bug.