Address bar spoofing on iOS using long hostnames
Categories
(Firefox for iOS :: General, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| fxios | 134 | --- |
People
(Reporter: chromium.khalil, Unassigned, NeedInfo)
References
()
Details
(Keywords: csectype-spoof, sec-low, Whiteboard: [fixed in fxiOS PR 19733])
Attachments
(2 files)
| Reporter | ||
Comment 1•8 years ago
|
||
Updated•8 years ago
|
| Reporter | ||
Comment 2•8 years ago
|
||
Updated•8 years ago
|
| Reporter | ||
Updated•8 years ago
|
| Reporter | ||
Comment 3•8 years ago
|
||
| Reporter | ||
Comment 4•8 years ago
|
||
| Reporter | ||
Comment 5•8 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
This is more of a feature request, we should align with Android on how we show the URL.
Android ticket is: https://bugzilla.mozilla.org/show_bug.cgi?id=1656735
Updated•3 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 12•1 year ago
|
||
Based on what I can see in this ticket, we should be able to resolve this as fixed with the new iOS toolbar redesign which AFAIK is slated to roll out in v133. If anyone believes that's not correct please LMK.
The related Jira for this ticket is still in QA Needed status however so I will wait until it's validated to mark as Resolved.
Comment 13•1 year ago
|
||
Verified as fixed on v133 (46984) with iPhone 15 Pro (18.2) with the new iOS Toolbar experiment.
With the new iOS Toolbar -> it is correctly displayed and the badssl.com is displayed in the URL.
But without the new iOS Toolbar -> the badssl.com is not displayed.
Matt if you consider the above ones are enough we can close this and the Jira ticket.
Comment 14•1 year ago
|
||
Based on the info I've seen so far, the plan on iOS is to eventually move to the new toolbar design for all users. So as long as this is addressed with the experiment enabled I think we can safely close. My only concern is that this will be published as fixed for whatever version the Bugzilla is tagged in (currently v133), which means if we're running any type of A/B experiment or phased rollout where some users still have the old toolbar, the security issue is still present.
@dveditz Do you know offhand how we typically handle fixes that are part of incremental rollouts? I am double-checking the plan on iOS but wanted to make sure the ticket was flagged correctly and we didn't publish the advisory too early.
Comment 15•1 year ago
|
||
Usually we don't publish it as "fixed" until it is fixed for everyone, that is, after the roll-out is complete. There's a subset of users who turn off experiments (at least on Desktop... don't know what the iOS population is like).
Comment 16•1 year ago
|
||
Are there bugzilla bugs for the new toolbar, or at least the experiment? If so they should be added to the "Depends on" field.
I think I've found the relevant Jira tickets and added them to the "see also". Please correct these if wrong.
- FXIOS-8038 is the Toolbar Redesign epic
- FXIOS-8728 appears to be this bug specifically ("Display effective TLD in url text field")
- the patch itself was in https://github.com/mozilla-mobile/firefox-ios/pull/19733
According to FXIOS-8038, v133 is only a "Beta experiment" it's not right to consider that version anyway. v134 is starting with a 20% roll-out, with v135 being the full target version. "135" isn't an option yet so I moved it to 134; not really right either, but more accurate than blank?
Often for desktop projects like this we have a separate "turn it on in release by default" task bug, but I didn't see anything like that. Does the iOS team use the status of the Epic itself for that? If you do have something like that then it would be useful to link it here, also.
Comment 17•1 year ago
|
||
I might have incomplete information but my understanding was that the new toolbar experiment is rolling out in v133. I think either Andy or Winnie would be best to confirm that though.
@nfurlan: can you possibly confirm how the experiment rollout for the new toolbar will proceed?
Comment 18•1 year ago
|
||
Given that we're currently rolling out the new toolbar experiment I'm going to mark as Resolved for the tagged fix version. I haven't been able to get full clarity around the rollout phases but I believe we're far enough now to consider this as a fixed.
Comment 19•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 20•1 year ago
|
||
Given how long it's taking to role out the new toolbar experience, in hindsight we should not have released an advisory for this until the fix was fully rolled out. An advisory says "if you upgrade to this version you will be safe from this bug", but that's not true with a partial roll-out like this. We should consider a roll-out like this as a kind of "extended beta".
Not quite sure how we'd track that so we don't forget to issue the advisory when it does finally get out to everyone. keep bumping the fxios tracking version one release ahead at a time, and ask about the roll-out status when we get to release time? In the Desktop and Android products we would make a bug like this "depend on" a tracking bug like "enable XXX for release" or "roll-out XXX to 100%", and then when those are are finally fixed that would trigger checking the bugs that depend on it. But the fxios team tracks most of their bugs elsewhere so that may not work as well.
Updated•1 year ago
|
| Reporter | ||
Comment 22•1 year ago
|
||
Doesn't this qualify for a bounty? Thanks.
| Reporter | ||
Updated•1 year ago
|
Comment 23•1 year ago
|
||
There had not been a request for one until now. If you are interested in the bounty please use the form linked to from our bug bounty page, or follow the mailing instructions for ones that were filed without the form.
Updated•1 year ago
|
Updated•1 year ago
|
Updated•10 days ago
|
Description
•