1419344 - Adjust OpenVR input mapping for Microsoft Mixed Reality controllers

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Daosheng Mu[:daoshengmu]]

Currently, the input mapping of OpenVR controllers for Windows MR is different from Windows MR in Edge browser. We have to do some adjustment to make the content could be consistent.

Axis (0, 1) <---> Axis(2, 3). And Axis 1 needs to be flipped. Axis 3 need to flip?

Button 3 <---> Button 4.

Comment 1

[Daosheng Mu[:daoshengmu]]

Compare with Edge, we have a wrong implementation for the vertical axis value. (https://www.w3.org/TR/gamepad/#dom-gamepad-axes) In order to not affect the current VR content, we add a workaround for yAxis.

Comment 2

[Daniel Veditz [:dveditz]]

How could this be exploited as a security bug?

Comment 3

[Daosheng Mu[:daoshengmu]]

This is not a security actually. It is just a confidential bug, but I don't know how to uncheck the `Security-Sensitive` option.

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: 0001-Bug-1419344-Adjust-OpenVR-input-mapping-for-Microsof.patch

Currently, we do not have too much information about Windows MR from the OpenVR runtime. I think it should be a temporary fix for supporting Windows MR devices in Firefox. Regarding to yAxisInvert, that is because we follow the implementation that Chromium did, we have argued about this, but it doesn't be changed.

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8931286 [details] [diff] [review]
0001-Bug-1419344-Adjust-OpenVR-input-mapping-for-Microsof.patch

This LGTM.

Later, we may want to make similar adjustments of button orders for other OpenVR controllers.

Comment 6

[Daosheng Mu[:daoshengmu]]

The controllers of Windows MR didn't support haptic feedback yet. I have checked it when running https://webvr.info/samples/XX-vr-controllers.html on Edge. Therefore, there is no response when calling aVRSystem->TriggerHapticPulse() from OpenVR. We can watch if there is any update from their side afterward.

Comment 7

[Daosheng Mu[:daoshengmu]]

Please help land it to m-c.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Needs a rebased patch.

Comment 9

[Daosheng Mu[:daoshengmu]]

Attachment: 0001-Bug-1419344-Adjust-OpenVR-input-mapping-for-Microsof.patch

Carry the r+ from attachment 8931286 [details] [diff] [review]. I have rebased it with the current m-c, please help land it again. Thanks!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8932001 [details] [diff] [review]
0001-Bug-1419344-Adjust-OpenVR-input-mapping-for-Microsof.patch

Still doesn't apply to inbound tip for me :(

Comment 11

[Daosheng Mu[:daoshengmu]]

Attachment: 0001-Bug-1419344-Adjust-OpenVR-input-mapping-for-Microsof.patch

Sorry for the apply failure.

I have rebased it with the current inbound/branches/default/tip, please help land it again. (Carry the r+ from attachment 8931286 [details] [diff] [review]) Thanks!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8932306 [details] [diff] [review]
0001-Bug-1419344-Adjust-OpenVR-input-mapping-for-Microsof.patch

The issue with the patch ended up being Windows vs. Unix line endings. Applies fine with that fixed :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7f2b1503e77f334039a3fe8f3646a8f34bada8

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fa7f2b1503e7