1419390 - Add automated test for "Searching for bookmarks from the Bookmarks Sidebar works properly"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Ioana Crisan]

testrail link: https://testrail.stage.mozaws.net/index.php?/cases/view/4104

Preconditions: A dirty profile with reasonable amount of browsing history and bookmarks.

Steps:
1. Launch Firefox
2. Enable the Bookmarks Sidebar
3. Search for the name of a bookmarked website, using the search bar available in the sidebar
4. Search for a bookmark by tag, using the search bar available in the sidebar

Expected results:
Step 1: Firefox is successfully launched.
Step 2: The Bookmarks Sidebar is enabled and displayed at the left side.
Step 3: The bookmark searched for is found and displayed in the sidebar.
Step 4: The bookmark(s) having that tag or/and the URL associated is found and displayed in the sidebar.

Comment 1

[Ioana Crisan]

Attachment: search_bookmarks_sidebar

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

Did you mean to assign this to me Ioana? As you've attached a patch I suspect it should be assigned to you instead?

Comment 3

[Ioana Crisan]

Hi Dave! 
We assigned it to you just temporary. I don't know a person with rights to review the "bookmarks" tests. We intended to discuss about this in today's meeting but seems that the meeting was postponed until tomorrow. Can you help me with a name?

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

The assignee is the individual working on the bug, not the reviewer. If you view the patch and set the review flag you'll see suggested reviewers for this component. They appear to be Drew Willcoxon :adw, Justin Dolske [:Dolske], Marco Bonardo [::mak], and Mark Banner (:standard8).

Comment 5

[Ioana Crisan]

(In reply to Dave Hunt (:davehunt) from comment #4)
> The assignee is the individual working on the bug, not the reviewer. If you
> view the patch and set the review flag you'll see suggested reviewers for
> this component. They appear to be Drew Willcoxon :adw, Justin Dolske
> [:Dolske], Marco Bonardo [::mak], and Mark Banner (:standard8).

Thank you!

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 8930467 [details] [diff] [review]
search_bookmarks_sidebar

Review of attachment 8930467 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/tests/browser/browser_bookmarks_sidebar_search.js
@@ +1,2 @@
> +/**
> + *  Test searching for bookmarks(by title and by tag) from the Bookmarks sidebar.

Nit: Need a space between "bookmarks" and "("

@@ +55,5 @@
> +  });
> +
> +  // Cleanup.
> +  await PlacesUtils.bookmarks.eraseEverything();
> +  await PlacesTestUtils.clearHistory();

Please use PlacesUtils.bookmarks.eraseEverything() instead.  (The PlacesTestUtils shortcut is deprecated.)

Comment 7

[Ioana Crisan]

Attachment: search_bookmarks_sidebar_1

Performed the changes that Drew requested.

Comment 8

[Ioana Crisan]

Attachment: search_bookmarks_sidebar_2

try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc6904ed167e3578e6e526186a2c0a2d6f18f54f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bc8cdd5e716
Searching for bookmarks from the Bookmarks Sidebar works properly r=adw

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4bc8cdd5e716