testrail link: https://testrail.stage.mozaws.net/index.php?/cases/view/4104 Preconditions: A dirty profile with reasonable amount of browsing history and bookmarks. Steps: 1. Launch Firefox 2. Enable the Bookmarks Sidebar 3. Search for the name of a bookmarked website, using the search bar available in the sidebar 4. Search for a bookmark by tag, using the search bar available in the sidebar Expected results: Step 1: Firefox is successfully launched. Step 2: The Bookmarks Sidebar is enabled and displayed at the left side. Step 3: The bookmark searched for is found and displayed in the sidebar. Step 4: The bookmark(s) having that tag or/and the URL associated is found and displayed in the sidebar.
Did you mean to assign this to me Ioana? As you've attached a patch I suspect it should be assigned to you instead?
Hi Dave! We assigned it to you just temporary. I don't know a person with rights to review the "bookmarks" tests. We intended to discuss about this in today's meeting but seems that the meeting was postponed until tomorrow. Can you help me with a name?
The assignee is the individual working on the bug, not the reviewer. If you view the patch and set the review flag you'll see suggested reviewers for this component. They appear to be Drew Willcoxon :adw, Justin Dolske [:Dolske], Marco Bonardo [::mak], and Mark Banner (:standard8).
(In reply to Dave Hunt (:davehunt) from comment #4) > The assignee is the individual working on the bug, not the reviewer. If you > view the patch and set the review flag you'll see suggested reviewers for > this component. They appear to be Drew Willcoxon :adw, Justin Dolske > [:Dolske], Marco Bonardo [::mak], and Mark Banner (:standard8). Thank you!
Comment on attachment 8930467 [details] [diff] [review] search_bookmarks_sidebar Review of attachment 8930467 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/places/tests/browser/browser_bookmarks_sidebar_search.js @@ +1,2 @@ > +/** > + * Test searching for bookmarks(by title and by tag) from the Bookmarks sidebar. Nit: Need a space between "bookmarks" and "(" @@ +55,5 @@ > + }); > + > + // Cleanup. > + await PlacesUtils.bookmarks.eraseEverything(); > + await PlacesTestUtils.clearHistory(); Please use PlacesUtils.bookmarks.eraseEverything() instead. (The PlacesTestUtils shortcut is deprecated.)
Attachment #8930467 - Flags: review?(adw) → review+
Created attachment 8931253 [details] [diff] [review] search_bookmarks_sidebar_1 Performed the changes that Drew requested.
Created attachment 8934432 [details] [diff] [review] search_bookmarks_sidebar_2 try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc6904ed167e3578e6e526186a2c0a2d6f18f54f
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bc8cdd5e716 Searching for bookmarks from the Bookmarks Sidebar works properly r=adw
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.