Closed Bug 1419507 Opened 7 years ago Closed 7 years ago

Disable WebRTC by default in SeaMonkey until it is fixed

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr fixed, seamonkey2.55 fixed, seamonkey2.56 fixed, seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.56
Tracking Flags:
Tracking Status
seamonkey2.49esr --- fixed
seamonkey2.55 --- fixed
seamonkey2.56 --- fixed
seamonkey2.53 + fixed

People

(Reporter: isaacschemm, Assigned: isaacschemm)

References

Details

Attachments

(1 file)

1419507-disable-webrtc-prefs.patch
1.05 KB, patch
frg
: review+
iannbugzilla
: approval-comm-beta+
iannbugzilla
: approval-comm-esr52+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171115114231

Steps to reproduce:

Using SeaMonkey 2.49 on Windows 10: visited https://talky.io/ and started a video chat.


Actual results:

Saw the message: "Requesting access to your webcam & microphone. Please enable access if asked." No permissions prompt was shown (this is bug 956854).


Expected results:

The site should have detected that my browser didn't support WebRTC, and shown me a message to that effect.

WebRTC support is present in SeaMonkey but does not work properly. The page sees the getUserMedia method and calls it, but since there is no permissions prompt, it never receives a callback, which makes the page look like it's frozen.

Setting both "media.navigator.enabled" and "media.peerconnection.enabled" to false would remove getUserMedia (see https://wiki.mozilla.org/Media/getUserMedia) and allow the website to detect that WebRTC is not supported.
Set media.navigator.enabled and media.peerconnection.enabled to false by default
Attachment #8930786 - Flags: review?(frgrahl)
Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

Thanks. Please ask IanN for Beta and ESR52 approval.
Attachment #8930786 - Flags: review?(frgrahl) → review+
Assignee: nobody → isaacschemm
status-seamonkey2.49esr: --- → affected
status-seamonkey2.55: --- → affected
status-seamonkey2.56: --- → affected
Version: SeaMonkey 2.49 Branch → Trunk
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

Added IanN to r? for comm-esr52 and comm-beta
Attachment #8930786 - Flags: review+ → review?(iann_bugzilla)
Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

Almost right. You need to set the approval flags :) I readded r+ and set a? for you.

I assume you tested in comm-esr52 otherwise please add a comment.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: unspecific erros and problmes when a website asks for webrtc to be enabled.
Testing completed (on m-c, etc.): c-esr52
Risk to taking this patch (and alternatives if risky): none minor problem.
String changes made by this patch: --
Attachment #8930786 - Flags: review?(iann_bugzilla)
Attachment #8930786 - Flags: review+
Attachment #8930786 - Flags: approval-comm-esr52?
Attachment #8930786 - Flags: approval-comm-beta?
See Also: → 956854
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e5073cc8c66d
Disable WebRTC by default in SeaMonkey until bug 956854 is fixed. r=frg
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
status-seamonkey2.56: affected → fixed
Target Milestone: --- → Seamonkey2.56
Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

a=me
Attachment #8930786 - Flags: approval-comm-esr52?
Attachment #8930786 - Flags: approval-comm-esr52+
Attachment #8930786 - Flags: approval-comm-beta?
Attachment #8930786 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: