1419507 - Disable WebRTC by default in SeaMonkey until it is fixed

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Isaac Schemm]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171115114231

Steps to reproduce:

Using SeaMonkey 2.49 on Windows 10: visited https://talky.io/ and started a video chat.


Actual results:

Saw the message: "Requesting access to your webcam & microphone. Please enable access if asked." No permissions prompt was shown (this is bug 956854).


Expected results:

The site should have detected that my browser didn't support WebRTC, and shown me a message to that effect.

WebRTC support is present in SeaMonkey but does not work properly. The page sees the getUserMedia method and calls it, but since there is no permissions prompt, it never receives a callback, which makes the page look like it's frozen.

Setting both "media.navigator.enabled" and "media.peerconnection.enabled" to false would remove getUserMedia (see https://wiki.mozilla.org/Media/getUserMedia) and allow the website to detect that WebRTC is not supported.

Comment 1

[Isaac Schemm]

Attachment: 1419507-disable-webrtc-prefs.patch

Set media.navigator.enabled and media.peerconnection.enabled to false by default

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

Thanks. Please ask IanN for Beta and ESR52 approval.

Comment 3

[Isaac Schemm]

Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

Added IanN to r? for comm-esr52 and comm-beta

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

Almost right. You need to set the approval flags :) I readded r+ and set a? for you.

I assume you tested in comm-esr52 otherwise please add a comment.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: unspecific erros and problmes when a website asks for webrtc to be enabled.
Testing completed (on m-c, etc.): c-esr52
Risk to taking this patch (and alternatives if risky): none minor problem.
String changes made by this patch: --

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e5073cc8c66d
Disable WebRTC by default in SeaMonkey until bug 956854 is fixed. r=frg

Comment 6

[Ian Neal]

Comment on attachment 8930786 [details] [diff] [review]
1419507-disable-webrtc-prefs.patch

a=me

Comment 7

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/2d249d47d9ff9666287104ba7dd5984edcda2da6
https://hg.mozilla.org/releases/comm-esr52/rev/d00c656b99c7ee694b13203d2252a7bf99d23af6

Comment 8

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/af28dcec3940910cfbd7ebdce78d98c6fd846cca