1419537 - Unable to select close tabs to the right on pinned tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[njgodber]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

Close tabs to the right is unavailable on pinned tabs. I simply pinned a tab and noticed that the option wasn't available in the context menu. 


Actual results:

Item wasn't available in the context menu. Only available on the neighboring non-pinned tab. So to close all the non pinned tabs in firefox currently you must select close tabs to the right on the left most non pinned tab and then manually close the remaining tab which I feel is clunky. I understand pre 57 there were perhaps addons to get the desired behavior but this seems like a sensible default. 


Expected results:

I expected the item to be available and the action, upon selection, to be the closure of all non-pinned tabs to the right of the pinned tab (as is the behavior in Chrome).

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1419537 - Make 'Close Tabs to the Right' and 'Close Other Tabs' available on pinned tabs to close non-pinned ones.

Review commit: https://reviewboard.mozilla.org/r/207946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207946/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8937238 [details]
Bug 1419537 - Make 'Close Tabs to the Right' and 'Close Other Tabs' available on pinned tabs to close non-pinned ones.

https://reviewboard.mozilla.org/r/207946/#review214014

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ede05405b50
Make 'Close Tabs to the Right' and 'Close Other Tabs' available on pinned tabs to close non-pinned ones. r=jaws

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5ede05405b50

Comment 5

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2017-11-21)on Windows 10.
I retested everything on Latest Nightly 60.0a1 and beta 59.0b6 using Windows 10 x64, Ubuntu 16.04 and macOS 10.13 and now the pinned tabs have both the 'Close Tabs to the Right' and 'Close Other Tabs' commands available and functional.