Closed Bug 1419589 Opened 2 years ago Closed 2 years ago
Ensure all storage is removed when reset
Default() is called within the Contextual Identity service
To avoid privacy issues with regressions like bug 1347515, we should remove all site storage (cookies, localstorage, serviceworkers, etc), along with icons/colors/names when resetDefault() is called: https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/toolkit/components/contextualidentity/ContextualIdentityService.jsm#152
Comment on attachment 8930829 [details] [diff] [review] context3.patch This looks fine however the code is blocked on Bug 1419591 landing first right?
Attachment #8930829 - Flags: review?(jkt) → review+
Assuming we move minUserContextId to 1 we should also remove that from the function signature.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/213e5dc04b90 ContextualIdentityService should reset all the container data when resetting the identities, r=jkt
Backed out for failing Chrome tests on Linux Debug toolkit/content/tests/chrome/test_bug437844.xul Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e8813c46b4f3446389c4a333fa1697aa56f0c23d Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=213e5dc04b9090f3a5fb9fc74c7d4f36781e44e8 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=148337838&repo=mozilla-inbound&lineNumber=24398 INFO - GECKO(4887) | ++DOMWINDOW == 73 (0xd71b0000) [pid = 4887] [serial = 104] [outer = 0xcde53940] 24398 [task 2017-11-29T01:30:02.580Z] 01:30:02 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_bug437844.xul | assertion count 37 is more than expected 17 to 36 assertions 24399 [task 2017-11-29T01:30:02.582Z] 01:30:02 INFO - TEST-START | toolkit/content/tests/chrome/test_bug451540.xul
This test seems completely unrelated are we sure this was the cause of it?
The c3 failures were quite frequent, and there was a push to try with the changes from here and Bug 1419591 backed out https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae6b050df7dcf29da2f00465387a9998c3bccf94 It seems that the tests from the above push passed, so it pointed to this push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=213e5dc04b9090f3a5fb9fc74c7d4f36781e44e8 as being the culprit for the failures. If needed, I will look again into it.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/1eafaf6a7642 ContextualIdentityService should reset all the container data when resetting the identities, r=jkt
You need to log in before you can comment on or make changes to this bug.