Closed
Bug 1419665
Opened 7 years ago
Closed 7 years ago
Support babel object-rest-spread syntax for launchpad
Categories
(DevTools :: Netmonitor, enhancement, P2)
DevTools
Netmonitor
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
Attachments
(1 file)
Launchpad is broken due to regression from bug 1408182. Bug 1408182 introduced object rest spread syntax which has built-in in Firefox, but we should setup babel config to support it on launchpad.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8930815 [details] Bug 1419665 - Support babel object-rest-spread syntax for launchpad https://reviewboard.mozilla.org/r/201910/#review207260 ::: devtools/client/netmonitor/yarn.lock:4448 (Diff revision 1) > > require-main-filename@^1.0.1: > version "1.0.1" > resolved "https://registry.yarnpkg.com/require-main-filename/-/require-main-filename-1.0.1.tgz#97f717b69d48784f5f526a6c5aa8ffdda055a4d1" > > -reselect@^2.5.4: > +reselect@^3.0.1: We're currently using "reselect": "^3.0.1", so yarn.lock must to be upgraded accordingly.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8930815 [details] Bug 1419665 - Support babel object-rest-spread syntax for launchpad https://reviewboard.mozilla.org/r/201910/#review207282 Looks good, thanks Ricky, R+ Honza
Attachment #8930815 -
Flags: review?(odvarko) → review+
| Comment hidden (mozreview-request) |
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18f77ef35a22 Support babel object-rest-spread syntax for launchpad r=Honza
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/18f77ef35a22
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•