1419665 - Support babel object-rest-spread syntax for launchpad

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Ricky Chien [:rickychien] (inactive)]

Launchpad is broken due to regression from bug 1408182. Bug 1408182 introduced object rest spread syntax which has built-in in Firefox, but we should setup babel config to support it on launchpad.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1419665 - Support babel object-rest-spread syntax for launchpad

Review commit: https://reviewboard.mozilla.org/r/201910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201910/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8930815 [details]
Bug 1419665 - Support babel object-rest-spread syntax for launchpad

https://reviewboard.mozilla.org/r/201910/#review207260

::: devtools/client/netmonitor/yarn.lock:4448
(Diff revision 1)
>  
>  require-main-filename@^1.0.1:
>    version "1.0.1"
>    resolved "https://registry.yarnpkg.com/require-main-filename/-/require-main-filename-1.0.1.tgz#97f717b69d48784f5f526a6c5aa8ffdda055a4d1"
>  
> -reselect@^2.5.4:
> +reselect@^3.0.1:

We're currently using "reselect": "^3.0.1", so yarn.lock must to be upgraded accordingly.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8930815 [details]
Bug 1419665 - Support babel object-rest-spread syntax for launchpad

https://reviewboard.mozilla.org/r/201910/#review207282

Looks good, thanks Ricky,
R+
Honza

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8930815 [details]
Bug 1419665 - Support babel object-rest-spread syntax for launchpad

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201910/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18f77ef35a22
Support babel object-rest-spread syntax for launchpad r=Honza

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/18f77ef35a22