Have a temporary quirk for CORS Response with same-origin mode Request with a pref

RESOLVED WONTFIX

Status

()

enhancement
P2
normal
RESOLVED WONTFIX
2 years ago
a year ago

People

(Reporter: tt, Assigned: tt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
Please refer to bug 1222008 comment #55.

Basically, when the service worker intercepts a "same-origin" mode request and responds a "Cors" type response, we would like to reject the promise. However, we need to deal with this case after collecting data in bug 1416629.

Thus, the temporary solution for this is to have a pref which have a method to trim the response and turn it on by default. 

The method to trim the response should behave the same as the following js executed in the service worker's script:
  
var quirkResponse = new Response(corsResponse.body, corsResponse);
Assignee

Comment 1

2 years ago
It should be a follow-up patch instead of a follow-up bug
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
Assignee

Comment 2

2 years ago
Reopen the bug since we decide to reject the promise by default and add a pref for enabling the quirk response.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee

Updated

2 years ago
Status: REOPENED → ASSIGNED
Ha!  I forgot you wrote this bug and I asked you to close it before.  So sorry for the back and forth.
Assignee

Comment 4

2 years ago
Posted patch wipSplinter Review
Tom, given the low hit rate on the telemetry in both Firefox and chrome so far, let's wait to put any more effort in here for a while.  We can check the telemetry again in January and add the quick before 59 merged to beta then, if necessary.

Sound reasonable?
Assignee

Comment 6

2 years ago
(In reply to Ben Kelly [:bkelly] from comment #5)
> Tom, given the low hit rate on the telemetry in both Firefox and chrome so
> far, let's wait to put any more effort in here for a while.  We can check
> the telemetry again in January and add the quick before 59 merged to beta
> then, if necessary.
> 
> Sound reasonable?

Yeah, sounds reasonable. Thanks!
Priority: -- → P2
Sounds reasonable.  Can you look at updating the tests we marked expected fail for this change?  We should also signal to the spec we want to ship this.
Assignee

Updated

a year ago
See Also: → 1427978
Assignee

Comment 9

a year ago
(In reply to Ben Kelly [:bkelly] from comment #8)
> Sounds reasonable.  Can you look at updating the tests we marked expected
> fail for this change?  We should also signal to the spec we want to ship
> this.

Sure, I filed bug 1427978 for it.
Assignee

Comment 10

a year ago
Mark this bug as "won't fix" based on the result of collecting data in comment #7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years agoa year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.