1419734 - Useless tab stats computation in gDevToolsBrowser

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

We used to compute some statistics about tabs being opened/closed for telemetry in gDevtoolsBrowser.
But it looks like we removed the telemetry record without removing the code that compute the statistics numbers:
https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/devtools/client/framework/devtools-browser.js#722-741
https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/devtools/client/framework/devtools-browser.js#479-482

We may save some milliseconds by removing that code.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1419734 - Remove tab statistics leftovers.

Review commit: https://reviewboard.mozilla.org/r/202072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202072/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8930983 [details]
Bug 1419734 - Remove tab statistics leftovers.

https://reviewboard.mozilla.org/r/202072/#review207752

Looks good, thanks for the cleanup!

::: commit-message-5378d:1
(Diff revision 1)
> +Bug 1419734 - Remove tab statistics lefovers. r=jdescottes

nit: lefovers -> leftovers

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8930983 [details]
Bug 1419734 - Remove tab statistics leftovers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202072/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7a987404da5
Remove tab statistics leftovers. r=jdescottes

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/b7a987404da5