1419761 - Rename "histogram_tools.py" to "parse_histograms.py"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

Renaming this file [1] may look trivial, but there are some interesting dependencies: some upstream jobs (TMO aggregator?) might be fetching a copy of this file to do the parsing. As a consequence, when renaming this file, we should also point the dependent jobs to the new file name.

[1] - https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/toolkit/components/telemetry/histogram_tools.py

Comment 1

[Alessio Placitelli [:Dexter]]

Do you know if TMO (or any other project like the regression detector) fetches a copy of histogram_tools.py from mozilla-central?

Comment 2

[Chris H-C :chutten]

python_moztelemetry sorta does. It vendors a copy in using this script: https://github.com/mozilla/python_moztelemetry/blob/master/bin/update_histogram_tools The script will need updating, but as it appears to be run manually its failures would be noticed and rectified.

The aggregator uses moztelemetry's version: https://github.com/mozilla/python_mozaggregator/search?utf8=%E2%9C%93&q=histogram&type=

telemetry-batch-view doesn't use it.

mozilla/moztelemetry seems to not use it, though I'm not 100% sure.

ni?frank for any projects I'm missing.

Comment 3

[Frank Bertsch [:frank]]

Yup, the only dependency server-side should be python_moztelemetry; everywhere else should fetch it from there. We don't retrieve it in any Scala code, the histogram bucket generation is done separately in t-b-v.

Comment 4

[Alessio Placitelli [:Dexter]]

Hey Ryan, would you be interested in taking this one as well? It is slightly more involved than the previous one since it has a depedency.

Comment 5

[Ryan Leake]

(In reply to Alessio Placitelli [:Dexter] from comment #4)
> Hey Ryan, would you be interested in taking this one as well? It is slightly
> more involved than the previous one since it has a depedency.

Sure Alessio, I'd like to give it a go.

Comment 6

[Ryan Leake]

Once "histogram_tools.py" has been renamed and all textual occurrences have been updated, how can I update the python_moztelemetry script to reflect the changes?

Comment 7

[Alessio Placitelli [:Dexter]]

(In reply to Ryan Leake from comment #6)
> Once "histogram_tools.py" has been renamed and all textual occurrences have
> been updated, how can I update the python_moztelemetry script to reflect the
> changes?

You can file a PR against https://github.com/mozilla/python_moztelemetry/ to change these files: https://github.com/mozilla/python_moztelemetry/search?utf8=%E2%9C%93&q=histogram_tools.py&type=

Comment 8

[Ryan Leake]

Thanks Alessio. Do the files in python_moztelemetry need renaming themselves( e.g. update_histogram_tools renamed to update_parse_histogram)?

Comment 9

[Alessio Placitelli [:Dexter]]

(In reply to Ryan Leake from comment #8)
> Thanks Alessio. Do the files in python_moztelemetry need renaming
> themselves( e.g. update_histogram_tools renamed to update_parse_histogram)?

Yes please. Let's also change the README file if needed.

Comment 10

[Ryan Leake]

Do the changes to python_moztelemetry look ok? https://github.com/RyanLeake/python_moztelemetry/commit/c4265ddd79a908d1e8486dd910e7ff663b4b6544

Comment 11

[Alessio Placitelli [:Dexter]]

(In reply to Ryan Leake from comment #10)
> Do the changes to python_moztelemetry look ok?
> https://github.com/RyanLeake/python_moztelemetry/commit/
> c4265ddd79a908d1e8486dd910e7ff663b4b6544

From a quick look they make sense. Let's make a PR so that I can take a better look :-)

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/python_moztelemetry/pull/188

Comment 13

[Ryan Leake]

Attachment: Bug 1419761 - Rename 'histogram_tools.py' to 'parse_histograms.py'.

Review commit: https://reviewboard.mozilla.org/r/202808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202808/

Comment 14

[Alessio Placitelli [:Dexter]]

Comment on attachment 8931640 [details]
Bug 1419761 - Rename 'histogram_tools.py' to 'parse_histograms.py'.

https://reviewboard.mozilla.org/r/202808/#review208136

This looks good, thank you!

Comment 15

[Alessio Placitelli [:Dexter]]

Ryan, looks like the changes are failing code linting:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=194823f0a3ba65b1343f99ce383aceac275c5ebf&selectedJob=147413387

Could you please fix it and update your patch? If you want to check for linting errors locally, you can run the following command:

./mach lint -l flake8 toolkit/components/telemetry

Comment 16

[Ryan Leake]

Comment on attachment 8931640 [details]
Bug 1419761 - Rename 'histogram_tools.py' to 'parse_histograms.py'.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202808/diff/1-2/

Comment 17

[Ryan Leake]

(In reply to Alessio Placitelli [:Dexter] from comment #15)
> Ryan, looks like the changes are failing code linting:
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=194823f0a3ba65b1343f99ce383aceac275c5ebf&selectedJob=1
> 47413387
> 
> Could you please fix it and update your patch? If you want to check for
> linting errors locally, you can run the following command:
> 
> ./mach lint -l flake8 toolkit/components/telemetry

Should be good to go now!

Comment 18

[Alessio Placitelli [:Dexter]]

Thank you!

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5d69465077c
Rename 'histogram_tools.py' to 'parse_histograms.py'. r=Dexter

Comment 20

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c5d69465077c

Comment 21

[Dailin Zhang]

(In reply to Alessio Placitelli [:Dexter] from comment #18)
> Thank you!

DO YOU HAVE SOME EASY BUGS
I KNOW JAVA, C, A LITTLE ANDROID

Comment 22

[Alessio Placitelli [:Dexter]]

(In reply to Dailin Zhang from comment #21)
> (In reply to Alessio Placitelli [:Dexter] from comment #18)
> > Thank you!
> 
> DO YOU HAVE SOME EASY BUGS
> I KNOW JAVA, C, A LITTLE ANDROID

Please have a look at http://www.joshmatthews.net/bugsahoy/ or http://whatcanidoformozilla.org/