1419868 - Clean up naming/comments around the content-to-chrome offset field in TabChild

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

I was looking at using this code and noticed it's named, typed, and commented poorly. So I cleaned it up.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1419868 - Fix some inconsistent naming

The property in question is the offset from the content process to the
chrome process, but it gets called various things for historical
reasons. Let's be consistent and just call it the chrome offset
everywhere.

Also, in some places this was needlessly getting turned into a
nsIntPoint via ToUnknownPoint(), only to be turned back into a
LayoutDeviceIntPoint at all the use sites. So this patch also updates
some function signatures to avoid the needless conversion.

No functional changes.

Review commit: https://reviewboard.mozilla.org/r/202156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202156/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcb0ae75d55b4456fddff1f331b5250957230f40

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8931058 [details]
Bug 1419868 - Fix some inconsistent naming

https://reviewboard.mozilla.org/r/202156/#review207524

I'm technically not a peer for this, but seems straightfoward enough to me.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/509935980719
Fix some inconsistent naming r=mystor

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/509935980719