1419903 - stylo-chrome: Assertion failure: !node->AsElement()->HasServoData()

Status: RESOLVED DUPLICATE of bug 1419554

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

This happens in several tests. I can reproduce this on Windows locally in browser/base/content/test/forms/browser_selectpopup.js.

Looking at the code, it seems that we fail to clear all Servo data in ClearStaleServoData() somehow.

Stack is:
Assertion failure: !node->AsElement()->HasServoData(), at dom/base/nsDocument.cpp:4271
#01: mozilla::PresShell::Destroy (layout\base\presshell.cpp:1315)
#02: nsDocumentViewer::DestroyPresShell (layout\base\nsdocumentviewer.cpp:4658)
#03: nsDocumentViewer::Destroy (layout\base\nsdocumentviewer.cpp:1767)
#04: nsDocShell::Destroy (docshell\base\nsdocshell.cpp:5982)
#05: nsXULWindow::Destroy (xpfe\appshell\nsxulwindow.cpp:493)
#06: nsWebShellWindow::Destroy (xpfe\appshell\nswebshellwindow.cpp:787)
#07: nsGlobalWindowOuter::ReallyCloseWindow (dom\base\nsglobalwindowouter.cpp:6241)
#08: nsCloseEvent::Run (dom\base\nsglobalwindowouter.cpp:6012)
#09: nsThread::ProcessNextEvent (xpcom\threads\nsthread.cpp:1038)
#10: NS_ProcessNextEvent (xpcom\threads\nsthreadutils.cpp:513)
#11: mozilla::ipc::MessagePump::Run (ipc\glue\messagepump.cpp:97)
#12: MessageLoop::RunHandler (ipc\chromium\src\base\message_loop.cc:320)
#13: MessageLoop::Run (ipc\chromium\src\base\message_loop.cc:300)
#14: nsBaseAppShell::Run (widget\nsbaseappshell.cpp:161)
#15: nsAppShell::Run (widget\windows\nsappshell.cpp:232)
#16: nsAppStartup::Run (toolkit\components\startup\nsappstartup.cpp:288)
#17: XREMain::XRE_mainRun (toolkit\xre\nsapprunner.cpp:4685)
#18: XREMain::XRE_main (toolkit\xre\nsapprunner.cpp:4847)
#19: XRE_main (toolkit\xre\nsapprunner.cpp:4942)
#20: do_main (browser\app\nsbrowserapp.cpp:232)
#21: NS_internal_main (browser\app\nsbrowserapp.cpp:306)
#22: wmain (toolkit\xre\nswindowswmain.cpp:114)
#23: __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
#24: BaseThreadInitThunk[C:\WINDOWS\System32\KERNEL32.DLL +0x12774]
#25: RtlUserThreadStart[C:\WINDOWS\SYSTEM32\ntdll.dll +0x70d51]

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Good, good, that's what those assertions mean to catch :).

Mind pushing a try run with the patch from bug 1419554? If there are others that remain, I can take a look.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I expect a couple of those to be fixed by that bug, if not all.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e5777e9b09b00a800809d833d2c00b202056d7a

The original failing tests are M-e10s(4 bc2) on Windows and macOS: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a406c371345e405a3df82b10f0dd2275fe78778

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

That patch seems to fix all of the failures here.