Remove the "menulist-description" binding

RESOLVED FIXED in Firefox 60

Status

()

P5
normal
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: bgrins, Assigned: 36198)

Tracking

(Blocks: 1 bug)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 wontfix, firefox59 wontfix, firefox60 fixed)

Details

(Whiteboard: [xbl-available])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The menu-vertical binding (bound to menulist[type=description]) appears to be unused in m-c: https://searchfox.org/mozilla-central/search?q=type%3D%22description%22&path=xul

The binding, along with any associated CSS can be removed: https://searchfox.org/mozilla-central/search?q=menulist-description&path=.

Note that there is a single consumer in comm-central, so either that will have to become a plain menulist or the binding will need to be migrated there to continue working: https://searchfox.org/comm-central/search?q=type%3D%22description%22&path=xul. It appears that the difference (some extra flex and different styling) could be migrated as CSS-only and not require porting the binding.
status-firefox58: --- → wontfix
status-firefox59: --- → fix-optional
Priority: -- → P5
(Assignee)

Comment 1

10 months ago
Created attachment 8944590 [details] [diff] [review]
bug.patch
Attachment #8944590 - Flags: review?(bgrinstead)

Updated

10 months ago
Depends on: 1432592
(Reporter)

Updated

10 months ago
Assignee: nobody → 36198
Status: NEW → ASSIGNED
(Reporter)

Updated

10 months ago
Attachment #8944590 - Flags: review?(bgrinstead) → review+
(Reporter)

Updated

10 months ago
Keywords: checkin-needed

Comment 4

10 months ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efb319fac7c3
Removed the unused menulist-description binding r=bgrins
Keywords: checkin-needed

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/efb319fac7c3
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
status-firefox59: fix-optional → wontfix
You need to log in before you can comment on or make changes to this bug.