Open Bug 1420002 Opened 7 years ago Updated 2 years ago

Have Debugger.Frame.eval construct scope chain for EvalSharedContext

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox59 --- fix-optional

People

(Reporter: tcampbell, Unassigned)

References

(Blocks 1 open bug)

Details

As Jason pointed out in Bug 1397049, the comments didn't make a lot of sense. It seems that the code doesn't make a huge amount of sense either. There should be further testing in of how the debugger eval interacts with different language features such as nested evals, arrow functions, and with blocks. I'd also like to see further testing around lexical scopes and debug evals inside them. Testing around creating functions in a debugger environment and then assigning them to an existing binding so script can interact after the debugger is done would be interesting too. I also would like to propose that the hack in EvalSharedContext been removed and instead (debugger) EvaluateInEnv conjure up an appropriate environment. The debug eval environment has some subtleties and I would rather we explicitly create the scope chain / environment chain in EvaluateInEnv. I'm not sure anyone can give an accurate answer right now for what the debug eval environment and parse context is for our users.
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.