Closed Bug 1420055 Opened 7 years ago Closed 7 years ago

[Leanplum] Drop an event when user finish first run on-boarding.

Categories

(Firefox for Android Graveyard :: General, enhancement)

ARM
Android
enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: cnevinchen, Assigned: cnevinchen)

Details

(Whiteboard: [FNC][SPT59.2][MVP])

Attachments

(1 file)

      No description provided.
Assignee: nobody → cnevinchen
Comment on attachment 8931229 [details]
Bug 1420055 - Drop an event when user finish first run on-boarding.

https://reviewboard.mozilla.org/r/202346/#review208028
Attachment #8931229 - Flags: review?(max) → review+
Hi Wesly
Please help clarify the requirement before I land this.

1. We drop the event whenever a user leaves first run onboarding (any of the four slides)
2. We only drop the event when a user click on "Start Browsing" ( the button on the last slide)

My current patch is 1
Flags: needinfo?(wehuang)
OS: Unspecified → Android
Hardware: Unspecified → ARM
Version: unspecified → Trunk
(In reply to Nevin Chen [:nechen] from comment #3)
> Hi Wesly
> Please help clarify the requirement before I land this.
> 
> 1. We drop the event whenever a user leaves first run onboarding (any of the
> four slides)
> 2. We only drop the event when a user click on "Start Browsing" ( the button
> on the last slide)
> 
> My current patch is 1

Per what I learned from the meeting with Jean it's (1), let's get Jean's confirmaton again. (ni-ed Jean)
Flags: needinfo?(wehuang) → needinfo?(jcollings)
Whiteboard: [FNC][SPT59.2][MVP]
Yes it's (1), thanks!
Flags: needinfo?(jcollings)
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28670a4ceeca
Drop an event when user finish first run on-boarding. r=maliu
https://hg.mozilla.org/mozilla-central/rev/28670a4ceeca
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Nevin,
I need to update my document: https://docs.google.com/spreadsheets/d/1XLwjK7eZgDD7ncbQ2Jm37aEMRiylLekOze4u9yEXSeM/edit#gid=599396862

Can you let me know what the Event name is and confirm it's landing in Fx59 for release?
Flags: needinfo?(cnevinchen)
it's E_Dismiss_Onboarding. Thanks!
Flags: needinfo?(cnevinchen) → needinfo?(jcollings)
Flags: needinfo?(jcollings)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: