Closed Bug 1420193 Opened 3 years ago Closed 3 years ago

Add Connect Another Device button to Sync onboarding panel

Categories

(Firefox :: Sync, enhancement, P1)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: rfeeley, Assigned: eoger)

References

Details

Attachments

(2 files)

This is a bug to update onboarding UI for current syncers to make it easier for them to connect another device.

1. Add a "Connect Another Device" to the onboarding panel for Sync for when users are currently syncing (all numbers of devices)

The button URL should be:
https://accounts.firefox.com/connect_another_device?service=sync&context=fx_desktop_v3&entrypoint=uitour
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
I'm not sure we should do this. The page that you are taken too has essentially the same information as the tour page. There's nothing additional you can do on https://accounts.firefox.com/connect_another_device?service=sync&context=fx_desktop_v3&entrypoint=uitour except use the store links (which people generally don't do). 

This is probably better addressed by making the content on the tour page more effective. That is something the onboarding team is starting to working on. We should involve Ryan in it.
Please do!

I think of the button as a quick win.

The page you see today will change and get smarter, like showing QR codes for mobile users.

Is there harm in doing this in the short term?
Flags: needinfo?(mverdi)
(In reply to Ryan Feeley [:rfeeley] from comment #3)
> Is there harm in doing this in the short term?

I don't think there is harm. It just seems odd to me to give people a button before there is value on the next page. What do you think about:
* Adding the app store buttons to the tour page for the quick win (saves people a click).
And then 
* Add the button when there is something smarter on the next page.
Flags: needinfo?(mverdi)
Posting my patch so I don't lose it.
I'm thinking we should go ahead and add that button, we can always change the page later and make it more useful.
Go for it!
Comment on attachment 8932586 [details]
Bug 1420193 - Add Connect Another Device button to Sync onboarding panel.

https://reviewboard.mozilla.org/r/203648/#review214044

LGTM

::: browser/components/uitour/UITour-lib.js:564
(Diff revision 2)
>        value: configValue,
>      });
>    };
>  
>    /**
> -   * Request the browser open the Firefox Accounts page.
> +   * Request the browser to open the Firefox Accounts page.

English is strange, but I think the original version of this comment is more correct.

::: browser/components/uitour/UITour-lib.js:598
(Diff revision 2)
>        email
>      });
>    };
>  
>    /**
> +   * Request the browser to open the "Connect Another Device" Firefox Accounts page.

ditto here - drop the "to"

::: browser/components/uitour/UITour-lib.js:606
(Diff revision 2)
> +   * parameters for the URL opened by the browser for reasons of promotional
> +   * campaign tracking. Each attribute of the object must have a name that
> +   * is a string, begins with "utm_" and contains only only alphanumeric
> +   * characters, dashes or underscores. The values may be any string and will
> +   * automatically be encoded.
> +   * @since 31, 47 for `extraURLCampaignParams`

I think this "since" is wrong - it's a new function, so I expect it should be just "@since 59"
Attachment #8932586 - Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3b472edbfb9
Add Connect Another Device button to Sync onboarding panel. r=markh
Is my review still needed here?
Flags: needinfo?(eoger)
Oops, I messed up! I asked for backout.
Flags: needinfo?(eoger)
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e46dd3c8e600
Backed out changeset b3b472edbfb9 for missing a review r=backout a=backout on a CLOSED TREE
Comment on attachment 8932586 [details]
Bug 1420193 - Add Connect Another Device button to Sync onboarding panel.

https://reviewboard.mozilla.org/r/203648/#review214320
Attachment #8932586 - Flags: review?(dtownsend) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19283f36ef75
Add Connect Another Device button to Sync onboarding panel. r=markh,mossop
https://hg.mozilla.org/mozilla-central/rev/19283f36ef75
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Flags: needinfo?(eoger)
You need to log in before you can comment on or make changes to this bug.