1420193 - Add Connect Another Device button to Sync onboarding panel

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Ryan Feeley [:rfeeley]]

Attachment: connect-another-device.png

This is a bug to update onboarding UI for current syncers to make it easier for them to connect another device.

1. Add a "Connect Another Device" to the onboarding panel for Sync for when users are currently syncing (all numbers of devices)

The button URL should be:
https://accounts.firefox.com/connect_another_device?service=sync&context=fx_desktop_v3&entrypoint=uitour

Comment 1

[Shane Tomlinson [:stomlinson]]

Ref https://github.com/mozilla/fxa-content-server/issues/5737

Comment 2

[Verdi [:verdi] Best to slack me]

I'm not sure we should do this. The page that you are taken too has essentially the same information as the tour page. There's nothing additional you can do on https://accounts.firefox.com/connect_another_device?service=sync&context=fx_desktop_v3&entrypoint=uitour except use the store links (which people generally don't do). 

This is probably better addressed by making the content on the tour page more effective. That is something the onboarding team is starting to working on. We should involve Ryan in it.

Comment 3

[Ryan Feeley [:rfeeley]]

Please do!

I think of the button as a quick win.

The page you see today will change and get smarter, like showing QR codes for mobile users.

Is there harm in doing this in the short term?

Comment 4

[Verdi [:verdi] Best to slack me]

(In reply to Ryan Feeley [:rfeeley] from comment #3)
> Is there harm in doing this in the short term?

I don't think there is harm. It just seems odd to me to give people a button before there is value on the next page. What do you think about:
* Adding the app store buttons to the tour page for the quick win (saves people a click).
And then 
* Add the button when there is something smarter on the next page.

Comment 5

[Edouard Oger [:eoger]]

Attachment: Bug 1420193 - Add Connect Another Device button to Sync onboarding panel.

Review commit: https://reviewboard.mozilla.org/r/203648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203648/

Comment 6

[Edouard Oger [:eoger]]

Posting my patch so I don't lose it.
I'm thinking we should go ahead and add that button, we can always change the page later and make it more useful.

Comment 7

[Ryan Feeley [:rfeeley]]

Go for it!

Comment 8

[Edouard Oger [:eoger]]

Comment on attachment 8932586 [details]
Bug 1420193 - Add Connect Another Device button to Sync onboarding panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203648/diff/1-2/

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8932586 [details]
Bug 1420193 - Add Connect Another Device button to Sync onboarding panel.

https://reviewboard.mozilla.org/r/203648/#review214044

LGTM

::: browser/components/uitour/UITour-lib.js:564
(Diff revision 2)
>        value: configValue,
>      });
>    };
>  
>    /**
> -   * Request the browser open the Firefox Accounts page.
> +   * Request the browser to open the Firefox Accounts page.

English is strange, but I think the original version of this comment is more correct.

::: browser/components/uitour/UITour-lib.js:598
(Diff revision 2)
>        email
>      });
>    };
>  
>    /**
> +   * Request the browser to open the "Connect Another Device" Firefox Accounts page.

ditto here - drop the "to"

::: browser/components/uitour/UITour-lib.js:606
(Diff revision 2)
> +   * parameters for the URL opened by the browser for reasons of promotional
> +   * campaign tracking. Each attribute of the object must have a name that
> +   * is a string, begins with "utm_" and contains only only alphanumeric
> +   * characters, dashes or underscores. The values may be any string and will
> +   * automatically be encoded.
> +   * @since 31, 47 for `extraURLCampaignParams`

I think this "since" is wrong - it's a new function, so I expect it should be just "@since 59"

Comment 10

[Edouard Oger [:eoger]]

Comment on attachment 8932586 [details]
Bug 1420193 - Add Connect Another Device button to Sync onboarding panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203648/diff/2-3/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3b472edbfb9
Add Connect Another Device button to Sync onboarding panel. r=markh

Comment 12

[Dave Townsend [:mossop] (PTO until July 20)]

Is my review still needed here?

Comment 13

[Edouard Oger [:eoger]]

Oops, I messed up! I asked for backout.

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e46dd3c8e600
Backed out changeset b3b472edbfb9 for missing a review r=backout a=backout on a CLOSED TREE

Comment 15

[Andrei Ciure[:aciure]]

Backed out changeset b3b472edbfb9 (bug 1420193) for missing a review r=backout a=backout on a CLOSED TREE

https://hg.mozilla.org/integration/autoland/rev/e46dd3c8e6001ee821411c15b1466d54fe723f1a

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b3b472edbfb9f445e425c5977012ef6ba34032cd&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Comment 16

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8932586 [details]
Bug 1420193 - Add Connect Another Device button to Sync onboarding panel.

https://reviewboard.mozilla.org/r/203648/#review214320

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19283f36ef75
Add Connect Another Device button to Sync onboarding panel. r=markh,mossop

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/19283f36ef75