1420368 - UITests failed to run

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Isabel Rios[:isabel_rios]]

This is the error shown in logs:

xcodebuild[7578:37559] Error Domain=IDETestOperationsObserverErrorDomain Code=6 "Early unexpected exit, operation never finished bootstrapping - no restart will be attempted" UserInfo={NSLocalizedDescription=Early unexpected exit, operation never finished bootstrapping - no restart will be attempted}

https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a1781d61d4bdd00019f3948#logs

This is happening both in v10.x and master branches.

Locally can't launch the tests either. Error shown:

Thread 1: EXC_BAD_ACCESS (code=1, address=0x20)
in UIScrollViewSwizzled.swift file in the initialize() class

Comment 1

[Isabel Rios[:isabel_rios]]

This seems to be the commit causing the failure: 
8ea0e15803363b5bf66e1048f0cb7c8a36247421

https://github.com/mozilla-mobile/firefox-ios/commit/8ea0e15803363b5bf66e1048f0cb7c8a36247421

Bug 1417152: guard against NaN bounds being set on the scrollview (#3488)

Not sure why this change causes the tests to fail or if we should modify them.

Comment 2

[:garvan]

I see this happening on tests, should have it fixed shortly

Comment 3

[:garvan]

Attachment: Pull request

The proper comparator to check 'class type' is the '==' which uses 'isEqual function' comparison, not the '===' which compares object addresses.

Comment 4

[Isabel Rios[:isabel_rios]]

Comment on attachment 8932112 [details] [review]
Pull request

Thanks for fixing it that fast!

Comment 5

[:garvan]

landed on master and 10.x