1420393 - Follow up Bug 1418307: Unsuccessfully entered WebPageLoading - New FxScreenGraph

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

Although some tests seem to be working after bug 1418307 there are a few more that are still failing with this error.

testActivityStreamPages()
testSearchEngine()

And now it is more frecuently seen than before.

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Comment 2

[Isabel Rios[:isabel_rios]]

The error is in FxScreenGraph L#333: screenState.onEnterWaitFor("exists != true", element: app.progressIndicators.element(boundBy: 0), if: "waitForLoading == true")

Checking `Expect predicate `exists != 1` for object ProgressIndicator`
Assertion Failure: FxScreenGraph.swift:333: Unsuccessfully entered WebPageLoading

It seems that the cause is a timing issue when the progress bar existence is checked and if it is there or not still when the page is being loaded.

This PR tries to check that and so follow the test. After first run on BB affected tests are green. Will run it a few more times to see if the result is consistent

Comment 3

[Isabel Rios[:isabel_rios]]

Comment on attachment 8934170 [details] [review]
Pull Request

After running several times on BB, on ipad and iphone sim, this error has not appeared. Asking for r? 
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a25bf4e4b0210000195a75b

Comment 4

[Isabel Rios[:isabel_rios]]

Merged: https://github.com/mozilla-mobile/firefox-ios/commit/4a5da0c4acfe50366cad452584931b1d4e36c718