1420399 - GCRuntime::hasBufferedGrayRoots() is badly named

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Jon Coppeard (:jonco)]

This means 'did we successfully buffer the gray roots' not 'are there any buffered gray roots' and should be rename accordingly.

Comment 1

[Paul Bone [:pbone]]

I suggest hasValidGrayRootsBuffer.

Comment 2

[Paul Bone [:pbone]]

Hi Matthew.

Has someone give you a "good-first-bug" yet?  This is a good chance to use bugzilla and post a trivial change for review.

If you want this bug, change its status to assigned, write and test a patch, attach it to the bug and request that I review it (or sfink or jonco, since it's a GC bug).  Once the review succeeds you can add the "checkin-needed" keyword and watch as the sherifs add it to firefox.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Rename GCRuntime::hasBufferedGrayRoots()

Rename to hasValidGrayRootsBuffer which better matches the semantics of the
call.

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a073ca5eea32077832eb27016da1e00b4034260

Comment 5

[Paul Bone [:pbone]]

Comment on attachment 8936615 [details] [diff] [review]
Rename GCRuntime::hasBufferedGrayRoots()

Review of attachment 8936615 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/035c35133387
Rename GCRuntime::hasBufferedGrayRoots(). r=pbone

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/035c35133387