1420422 - Enable ESLint rule mozilla/use-services for services/

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Mark Banner (:standard8)]

As we've been doing elsewhere, we should turn on mozilla/use-services for services/ and avoid the overhead of going via .getService.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1420422 - Enable ESLint rule mozilla/use-services for services/.

Review commit: https://reviewboard.mozilla.org/r/202838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202838/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8931685 [details]
Bug 1420422 - Enable ESLint rule mozilla/use-services for services/.

https://reviewboard.mozilla.org/r/202838/#review208368

::: services/sync/tps/extensions/tps/resource/modules/prefs.jsm:14
(Diff revision 1)
>  
>  var EXPORTED_SYMBOLS = ["Preference"];
>  
>  const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
>  
> -const WEAVE_PREF_PREFIX = "services.sync.prefs.sync.";
> +const WEAVE_PREF_PREFIX = "services.sync.Services.prefs.sync.";

this change looks wrong

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Heads-up for Thom as this touches tps and that's not run by treeherder - I don't expect it to break anything, but just in case it does we've got a good starting point :)

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8931685 [details]
Bug 1420422 - Enable ESLint rule mozilla/use-services for services/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202838/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fa95cb5f014
Enable ESLint rule mozilla/use-services for services/. r=markh

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/3fa95cb5f014