Closed
Bug 1420422
Opened 8 years ago
Closed 8 years ago
Enable ESLint rule mozilla/use-services for services/
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
As we've been doing elsewhere, we should turn on mozilla/use-services for services/ and avoid the overhead of going via .getService.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8931685 [details]
Bug 1420422 - Enable ESLint rule mozilla/use-services for services/.
https://reviewboard.mozilla.org/r/202838/#review208368
::: services/sync/tps/extensions/tps/resource/modules/prefs.jsm:14
(Diff revision 1)
>
> var EXPORTED_SYMBOLS = ["Preference"];
>
> const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
>
> -const WEAVE_PREF_PREFIX = "services.sync.prefs.sync.";
> +const WEAVE_PREF_PREFIX = "services.sync.Services.prefs.sync.";
this change looks wrong
Attachment #8931685 -
Flags: review?(markh) → review+
|
|
||
Comment 3•8 years ago
|
||
Heads-up for Thom as this touches tps and that's not run by treeherder - I don't expect it to break anything, but just in case it does we've got a good starting point :)
| Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fa95cb5f014
Enable ESLint rule mozilla/use-services for services/. r=markh
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•