1420447 - Cannot install WebExtension addon showing warning: There is no item named 'install.rdf' in the archive

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

It seems that mozregression doesn't support installing WebExtension addons.

I tried to install the gecko profiler addon via "--addon gecko_profiler.xpi" in commandline, however, it isn't installed, and there is a warning:
> mozprofile.addons WARNING | Could not install gecko_profiler.xpi: "There is no item named 'install.rdf' in the archive"

Comment 1

[William Lachance (:wlach)]

It looks like support for web extensions only landed in mozprofile recently. With the in-tree version of mozprofile installed, gecko_profiler installs correctly. We'll need to release a new version of mozrunner (since the last version released is incompatible with the current in-tree version), then release the in-tree version of mozprofile, then bump the required versions in mozregression itself.

It seems like by default webextensions installed via mozprofile are disabled by default, I'm not sure if there's a preference we can tweak to enable them. :rwood, do you know?

Comment 2

[Robert Wood [:rwood]]

I don't know offhand, from a quick look where webextensions are installed in talos [1] I don't see any prefs being set besides turning off signatures required [2].

[1] https://searchfox.org/mozilla-central/rev/8839daefd69087d7ac2655b72790d3a25b6a815c/testing/talos/talos/ffsetup.py#132
[2] https://searchfox.org/mozilla-central/source/testing/talos/talos/test.py#158

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I assume that mozregression is using mozprofile? Support for that has been added via bug 1377510, but we actually never released a new version to PyPI.

Comment 5

[William Lachance (:wlach)]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> I assume that mozregression is using mozprofile? Support for that has been
> added via bug 1377510, but we actually never released a new version to PyPI.

I released a new version today.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh wonderful. Thanks a lot.

Comment 7

[William Lachance (:wlach)]

I also have a PR which uses the new version of mozprofile:

https://github.com/mozilla/mozregression/pull/475

But I'd like to figure out if we can't get the extensions enabled-by-default first.

Comment 8

[William Lachance (:wlach)]

Tarek, since you made the changes to mozprofile, maybe you would know? Do you have any idea on why webextensions installed via mozprofile are disabled by default? See rwood's remarks in comment 2.

Comment 9

[Tarek Ziadé (:tarek)]

The change I made in mozprofile does the following:

- copy the extension like it does for older xpi addons 
- read a few metadata from the manifest.json file and create a uuid in case the manifest provides no id - https://searchfox.org/mozilla-central/source/testing/mozbase/mozprofile/mozprofile/addons.py#326


I have not done anything in particular with respect to enabling/disabling web extensions, so maybe there's a missing step in the mozprofile code to actually enable the extension once it's copied ? I don't see anything in the manifest that refers to it - https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json

Comment 10

[William Lachance (:wlach)]

Thanks Tarek! Did some digging and I think we do indeed need to set a preference to allow sideloading extensions:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Alternative_distribution_options/Add-ons_in_the_enterprise

Setting extensions.autoDisableScopes to "0" seems to do the trick if I do it manually. I'll add that to the default mozregression preference set.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Btw. we should finally clean-up mozprofile from setting all those extra test harness related preferences, which should nowadays all be set in the appropriate harnesses. There should already be a bug for that.

Comment 12

[William Lachance (:wlach)]

(In reply to Henrik Skupin (:whimboo) from comment #11)
> Btw. we should finally clean-up mozprofile from setting all those extra test
> harness related preferences, which should nowadays all be set in the
> appropriate harnesses. There should already be a bug for that.

I believe those preferences are optional, but in general I agree. The preferences we use for running stuff in automation don't belong in mozprofile itself. Please file a new bug. :)

Comment 13

[William Lachance (:wlach)]

This should be working now (new versions of mozregression/gui released with the change)