Closed Bug 1420745 Opened 2 years ago Closed 9 months ago
(spike in 67 of) Crash in mozilla::layers::Compositor
47 bytes, text/x-phabricator-request
|Details | Review|
This bug was filed from the Socorro interface and is report bp-252c8d15-38fc-4b9d-a25e-620fe0171124. ============================================================= This is topcrash #3 in the android nightly 20171123100056. Top 10 frames of crashing thread: 0 libxul.so mozilla::layers::CompositorOGL::Initialize gfx/layers/opengl/CompositorOGL.cpp:238 1 libxul.so mozilla::layers::CompositorBridgeParent::NewCompositor gfx/layers/ipc/CompositorBridgeParent.cpp:1481 2 libxul.so mozilla::layers::CompositorBridgeParent::InitializeLayerManager gfx/layers/ipc/CompositorBridgeParent.cpp:1412 3 libxul.so mozilla::layers::CompositorBridgeParent::AllocPLayerTransactionParent gfx/layers/ipc/CompositorBridgeParent.cpp:1523 4 libxul.so mozilla::layers::PCompositorBridgeParent::OnMessageReceived ipc/ipdl/PCompositorBridgeParent.cpp:840 5 libxul.so mozilla::ipc::MessageChannel::DispatchAsyncMessage ipc/glue/MessageChannel.cpp:2114 6 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2044 7 libxul.so mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1923 8 libxul.so MessageLoop::RunTask ipc/chromium/src/base/message_loop.cc:452 9 libxul.so MessageLoop::DeferOrRunPendingTask ipc/chromium/src/base/message_loop.cc:460 =============================================================
Jim, do you know if recent changes to GeckoLayerClient and friends would have caused this?
Component: Graphics: Layers → Widget: Android
Flags: needinfo?(bugmail) → needinfo?(nchen)
I don't think they did. We seem to get these crashes for 57 and 58 as well.
This crash is currently #6 overall nightly on Fennec.
Almost 1500 crashes in the last week on 59.0.2. Is it possible for someone to take another look at this?
Petru, can one of you look at this ASAP? I think it may land in 59 or 60 if a fix is found.
Flags: needinfo?(sdaswani) → needinfo?(petru.lingurar)
Things I found: - the crashes started appearing December 26th 2017 from  although no recent changes seems to have been made to that file prior to the crashes. - before the line where the crash occurs the CreateContext() method is executed, but that method hasn't been modified in more than a year prior to the crashes - from the gathered crash reports there doesn't seem to be a clear scenario in which this crash would occur although there are a few situations which appeared appeared in 2-3 reports - try to do a search/tap the address bar - open the app in multi-window mode  https://hg.mozilla.org/releases/mozilla-release/annotate/d2e449c73dac/gfx/layers/opengl/CompositorOGL.cpp#l238  https://hg.mozilla.org/releases/mozilla-release/annotate/d2e449c73dac/gfx/layers/opengl/CompositorOGL.cpp#l111
Thanks Petru. Ryan, it looks like the crashes aren't related to a code change, per Petru's analysis. Do we have an idea if the crash is more prevalent on a set of devices or OS versions?
Petru's analysis only reflects the crash data purge in late December. Note that the bug was filed a month prior in November.
Ah, I wasn't away of the 'purge'. Petru can you spend some time trying to repro?
Indeed, the first crash appeared in September  but only in the last few months they've become more prevalent. Trying to reproduce based on the few comments in the crash reports (tapping in the address bar, multi-window), nothing yet.  First crash on 57.0b3 - https://crash-stats.mozilla.com/report/index/1eaed915-4848-4e95-b324-488e10180120
Marcia is this still a frequent crasher?
Looking at the affected devices I am seeing mostly emulator devices. Common ways to detect this are known ARM devices running on x86 and mentions of emulator or VMWare. unknown AOSP on ARM Emulator 18 (REL) armeabi-v7a 36 5.5% samsung SM-G960F 22 (REL) x86 25 3.8% zte Z982 22 (REL) x86 24 3.7% samsung SM-G950F 26 (REL) armeabi-v7a 18 2.7% gmbh VirtualBox 19 (REL) x86 16 2.4% innotek VirtualBox 19 (REL) x86 16 2.4% samsung GT-P5210 19 (REL) x86 15 2.3% oppo A37f 22 (REL) x86 14 2.1% lge Nexus 5X 27 (REL) armeabi-v7a 13 2.0% inc VMware Virtual Platform 19 (REL) x86 12 1.8% vmware VMware Virtual Platform 19 (REL) x86 12 1.8% samsung SM-A520F 22 (REL) x86 11 1.7%
As Kevin notes there is a mix of emulator devices in the recent 62 data (including betas). One of the top crashing devices is SM-G965U, which is the Samsung Galaxy S9. There aren't many URLs to try to reproduce. I think we wait and see how this plays out in 62 volume since we just shipped, and we can reevaluate at a later time.
Volume in 62.0.1 is pretty low so far - 193 crashes so far.
Updating affected branches. While there are some emulator devices, it appears as if a fair amount of regular devices crash as well. Volume is relatively low on 62/63/64.
Flags: needinfo?(snorp) → needinfo?(jgilbert)
Component: Widget: Android → Graphics
Flags: needinfo?(jgilbert) → needinfo?(snorp)
Assignee: nobody → jgilbert
Severity: critical → major
Depends on: 1528396
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b437ff8ed47c dlsym from lib before wsiGetProcAddress. r=snorp
Summary: Crash in mozilla::layers::CompositorOGL::Initialize → (spike in 67 of) Crash in mozilla::layers::CompositorOGL::Initialize
You need to log in before you can comment on or make changes to this bug.