1420778 - Download permission should be optional

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P5)

Description

[Eric Jung [:ericjung]]

A lot of addons are using browser.downloads.download() to export settings to a user's local filesystem. However, many users will never export. The "downloads" permission should be optional and requested when needed.

Comment 1

[Andy McKay]

Attachment: bug 1420778 make downloads permissions optional

Review commit: https://reviewboard.mozilla.org/r/225990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225990/

Comment 2

[Andy McKay]

Attachment: Screenshot 2018-03-07 16.06.27.png

As per chat in IRC, here's an attached image that downloads works as an optional permissions.

Comment 3

[Andy McKay]

Comment on attachment 8957023 [details]
bug 1420778 make downloads permissions optional

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225990/diff/1-2/

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8957023 [details]
bug 1420778 make downloads permissions optional

https://reviewboard.mozilla.org/r/225990/#review231878

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b781bef18f0
make downloads permissions optional r=aswan

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1b781bef18f0

Comment 7

[CosminB]

Attachment: Bug1420778.gif

This issue is verified as fixed on Firefox 60.0a1 (20180309003239) under Windows 7 64-bit and Mac OS X 10.13.2.

The "downloads" and "downloads.open" can be requested as optional permissions.

Please see the attached video.

I also filed a bug on addons-linter to update the API schema: https://github.com/mozilla/addons-linter/issues/1893

Comment 8

[Will Bamberg [:wbamberg]]

Docs are updated: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/optional_permissions