1420920 - Ability to unblock image when context menu is not accessible

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

Goto settings --> Advanced --> Show images --> WiFi only


Actual results:

Images blocked in cellular mode.


Expected results:

If I realize that images are essential on a webpage (e.g. important information or links just encoded as images) and I have them blocked outside of Wifi, the current way to load them is:

   Goto settings --> Advanced --> Show images --> Always --> Reload Page --> Goto settings --> Advanced --> Show images --> WiFi only

... what is quite cumbersome.

Since this feature does not yet exist, I would like to propose a "Load images" button somewhere (like the "Request Deskop Site") when in cellular networks and loading images is blocked outside of WiFi world.

Thanks a lot!
Stephan

Comment 1

[Jan Henning [:JanH]]

(In reply to [e-mail] from comment #0)
> ... what is quite cumbersome.

Absolutely understandable. But in fact something very similar is already in place:
When you unblock a single image (long-press the image to trigger the context menu and Show Image), Firefox pops up a message that allows you to load all remaining images in one go. Is there any particular reason why this doesn't work for you?

Comment 2

[[e-mail]]

(In reply to Jan Henning [:JanH] from comment #1)
> When you unblock a single image (long-press the image to trigger the context
> menu and Show Image), Firefox pops up a message that allows you to load all
> remaining images in one go. Is there any particular reason why this doesn't
> work for you?

Yes, indeed. Although I did not know about this "hidden feature", it does not work for the page I have trouble with. Even if I zoom in as much as possible, I can't get the context menu to open. It is unfortunately behind a login so I can't give you a link. If really needed, I might be able to generate a saved version of the page cleared from confidential content but I need some time for it. I made a screenshot and try to add it above.

Comment 3

[[e-mail]]

Attachment: Example1

Example where context menu does not pop up.

Comment 4

[[e-mail]]

The relevant HTML-code for the images is:

<div class="element-wrapper">
   <input id="fetch-20171127180000-date" name="fetch-20171127180000-date" value="2017-11-27 18:00:00" type="hidden">
   <ul class="imglist" id="fetch-20171127180000-imglist">
      <li class="filled fetch-20171127180000-144901">
         <a class="" href="#" onclick="profile(144901);return false;" title="String1"><input name="date" value="144901:::2017-11-27 18:00:00" type="hidden"><img src="/images/mini_q_401f521a7ed5e5d71d19b3cc2ddc21f4.jpg" alt="String1"><span>&nbsp;</span></a>
      </li>
      <li class="filled fetch-20171127180000-173664">
         <a class="" href="#" onclick="profile(173664);return false;" title="String2"><input name="date" value="173664:::2017-11-27 18:00:00" type="hidden"><img src="/img/mini_q_avatar.png" alt="String2"><span>&nbsp;</span></a>
      </li>
   </ul>
   <div style="clear:both;"></div>
</div>
<input id="fetch-20171127180000-error-msg" value="" type="hidden">
<div style="clear:both;"></div>

But nevertheless, I wouldn't have known about the context-menu possibility, if you wouldn't have told be. Hence an additional button sounds nice to me.

Comment 5

[Jan Henning [:JanH]]

Apart from a genuine bug there's also the possibility of a page blocking the context menu either through JS or by layering some transparent <div> in front of the image [1] or whatnot, and if that happens for *all* images on a page then you're indeed stuck.

[1] If I'm not mistaken, that's what's happening in your case through the <div style="clear:both;"></div> placed in front of the imglist <ul>. Thanks for providing that snippet.

Comment 6

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.