1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

Review commit: https://reviewboard.mozilla.org/r/203168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203168/

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks for adding me to the CC list!

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1420954 - Add NS_MutateURI helper function to chain nsIURIMutator setters in C++

Review commit: https://reviewboard.mozilla.org/r/203338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203338/

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8932132 [details]
Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203168/diff/1-2/

Comment 5

[Daniel Stenberg [:bagder]]

Comment on attachment 8932132 [details]
Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

https://reviewboard.mozilla.org/r/203168/#review210046

Comment 6

[Daniel Stenberg [:bagder]]

Comment on attachment 8932316 [details]
Bug 1420954 - Add NS_MutateURI helper function to chain nsIURIMutator setters in C++

https://reviewboard.mozilla.org/r/203338/#review210048

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8932132 [details]
Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203168/diff/2-3/

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8932316 [details]
Bug 1420954 - Add NS_MutateURI helper function to chain nsIURIMutator setters in C++

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203338/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480c6e1721e9
Make nsIURIMutator setters return nsIURIMutator so we can chain setters r=bagder
https://hg.mozilla.org/integration/autoland/rev/8ce0a0d49d9e
Add NS_MutateURI helper function to chain nsIURIMutator setters in C++ r=bagder

Comment 10

[Stefan Hindli [:stefan_hindli]]

Backed out 2 changesets (bug 1420954) for build failure in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h:340:3: r=backout on a CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=149327386
https://hg.mozilla.org/integration/autoland/rev/7a19568290c61d7a510b54455419b086e66cc6db

Comment 11

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9bba23819aa64cdecb58c6df0e65edda9182025

Comment 12

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1070fa646e6d137845b6a08673bafe65bdcc1e01

Comment 13

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28c14bdc30df780715a57b8083bb677ce50ddf09

Comment 14

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41e42f1ab59ad409b82bceef5ad129e4b2913ad4

Comment 15

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8932132 [details]
Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203168/diff/3-4/

Comment 16

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8932316 [details]
Bug 1420954 - Add NS_MutateURI helper function to chain nsIURIMutator setters in C++

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203338/diff/2-3/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a1f4c9feba0
Make nsIURIMutator setters return nsIURIMutator so we can chain setters r=bagder
https://hg.mozilla.org/integration/autoland/rev/33570a2d4633
Add NS_MutateURI helper function to chain nsIURIMutator setters in C++ r=bagder

Comment 18

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0a1f4c9feba0
https://hg.mozilla.org/mozilla-central/rev/33570a2d4633