Make nsIURIMutator setters return nsIURIMutator so we can chain setters

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: valentin, Assigned: valentin)

Tracking

(Blocks 1 bug)

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 attachments)

No description provided.

Comment 2

2 years ago
Thanks for adding me to the CC list!
Comment hidden (mozreview-request)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8932132 [details]
Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

https://reviewboard.mozilla.org/r/203168/#review210046
Attachment #8932132 - Flags: review?(daniel) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8932316 [details]
Bug 1420954 - Add NS_MutateURI helper function to chain nsIURIMutator setters in C++

https://reviewboard.mozilla.org/r/203338/#review210048
Attachment #8932316 - Flags: review?(daniel) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

2 years ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/480c6e1721e9
Make nsIURIMutator setters return nsIURIMutator so we can chain setters r=bagder
https://hg.mozilla.org/integration/autoland/rev/8ce0a0d49d9e
Add NS_MutateURI helper function to chain nsIURIMutator setters in C++ r=bagder
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 17

2 years ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0a1f4c9feba0
Make nsIURIMutator setters return nsIURIMutator so we can chain setters r=bagder
https://hg.mozilla.org/integration/autoland/rev/33570a2d4633
Add NS_MutateURI helper function to chain nsIURIMutator setters in C++ r=bagder

Comment 18

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a1f4c9feba0
https://hg.mozilla.org/mozilla-central/rev/33570a2d4633
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.