Closed
Bug 1420954
Opened 6 years ago
Closed 6 years ago
Make nsIURIMutator setters return nsIURIMutator so we can chain setters
Categories
(Core :: Networking, enhancement, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
Thanks for adding me to the CC list!
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8932132 [details] Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters https://reviewboard.mozilla.org/r/203168/#review210046
Attachment #8932132 -
Flags: review?(daniel) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8932316 [details] Bug 1420954 - Add NS_MutateURI helper function to chain nsIURIMutator setters in C++ https://reviewboard.mozilla.org/r/203338/#review210048
Attachment #8932316 -
Flags: review?(daniel) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/480c6e1721e9 Make nsIURIMutator setters return nsIURIMutator so we can chain setters r=bagder https://hg.mozilla.org/integration/autoland/rev/8ce0a0d49d9e Add NS_MutateURI helper function to chain nsIURIMutator setters in C++ r=bagder
Comment 10•6 years ago
|
||
Backed out 2 changesets (bug 1420954) for build failure in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h:340:3: r=backout on a CLOSED TREE https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=149327386 https://hg.mozilla.org/integration/autoland/rev/7a19568290c61d7a510b54455419b086e66cc6db
Assignee | ||
Comment 11•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9bba23819aa64cdecb58c6df0e65edda9182025
Assignee | ||
Comment 12•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1070fa646e6d137845b6a08673bafe65bdcc1e01
Assignee | ||
Comment 13•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28c14bdc30df780715a57b8083bb677ce50ddf09
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 14•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=41e42f1ab59ad409b82bceef5ad129e4b2913ad4
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 17•6 years ago
|
||
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0a1f4c9feba0 Make nsIURIMutator setters return nsIURIMutator so we can chain setters r=bagder https://hg.mozilla.org/integration/autoland/rev/33570a2d4633 Add NS_MutateURI helper function to chain nsIURIMutator setters in C++ r=bagder
Comment 18•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0a1f4c9feba0 https://hg.mozilla.org/mozilla-central/rev/33570a2d4633
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•