142096 - Message Security box does not display all recipients

Status: VERIFIED FIXED

(MailNews Core :: Security: S/MIME, defect, P3)

Description

[Pratik]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0+) Gecko/20020502
BuildID:    2002050221

If I have both To and CC receipients then the message security box does not
display information for everyone. It just seems to display information for all
CC receipients or all To receipients, not both

Reproducible: Always
Steps to Reproduce:
1.Compose a new message with 1 to and 1 cc address
2.Click on Message Security icon
3.

Actual Results:  just the cc or To is displayed in Certificates box

Expected Results:  Both To and CC should be displayed

Now Change the to to cc and press Message Security. You'll see that both the
receipients are displayed

Comment 1

[Charles Rosendahl]

Confirmed - Not sure when or how this was introduced, but it is not working at
the moment.

looks like an addressing widget integration issue.

Variance of the test case:
Have two rows with 'To' recipients
Have two rows with 'cc' or 'bcc' recipients
result - you will see three of the entries

Proposed we fix for RTM, adt2 or 3?

Comment 2

[Kai Engert [:KaiE:]]

I can see the bug on the branch, too.

I hope this will be a simple fix, I think the parser needs to care for " in the
lines.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Suggested Fix

Argh.

Comment 4

[Kai Engert [:KaiE:]]

Attachment: Patch v2.

Actually I like this patch better.

Comment 5

[Kai Engert [:KaiE:]]

Javi, can you please review?

Comment 6

[Javier Delgadillo]

Comment on attachment 83545 [details] [diff] [review]
Patch v2.

r=javi

Comment 7

[Scott MacGregor]

Comment on attachment 83545 [details] [diff] [review]
Patch v2.

sr=mscott

Comment 8

[Kai Engert [:KaiE:]]

Checked in to trunk.

Comment 9

[Charles Rosendahl]

Verified

Comment 10

[Kai Engert [:KaiE:]]

Raising priority to ADT 1.

I think most people using S/Mime will eventually run into this bug, because it
is highly likely to use both To and CC recipients.

Comment 11

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
Driver's approval. Pls check this in tonight, and add the fixed1.0.1 keyword.

Comment 12

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 13

[Kai Engert [:KaiE:]]

Checked in to branch.

Comment 14

[Charles Rosendahl]

Verified on 20020606 Branch builds.  It does display all recipients now.  As far
as I can tell, it displays their status correctly as well (not found/invalid/valid).

If the status display is incorrect for any reason in the future, this should be
filed as a separate bug.  

This bug is specific to displaying all recipients regardless of recipient type,
and nothing else.