Closed Bug 1421025 Opened 4 years ago Closed 4 years ago
'Support down-scaling per track in get
User Media' breaks --disable-webrtc
59 bytes, text/x-review-board-request
From Bug 1388219 I believe that the problem is that this line: https://hg.mozilla.org/integration/autoland/rev/341aaeb4ce69#l4.12 is not present in all the compilation units that sId (https://hg.mozilla.org/integration/autoland/rev/341aaeb4ce69#l1.12) is declared in. I don't know why this doesn't affect anyone other than MinGW though.
Ah, no that's partly true. The real problem is that MinGW turns on --disable-webrtc, and Bug 1388219 breaks that compilation target.
Flags: needinfo?(tom) → needinfo?(mchiang)
Summary: Permafailure gmake: *** [xul.dll] Error 1 → 'Support down-scaling per track in getUserMedia' breaks --disable-webrtc
Depends on: 1388219
4 years ago
Assignee: nobody → mchiang
4 years ago
Comment on attachment 8932346 [details] Bug 1421025 - fix build break with --disable-webrtc. https://reviewboard.mozilla.org/r/203386/#review208812 This LGTM assuming it builds successfully. However I don't have enough permissions for autoland to land commits r+-ed by me, so unless you do, you will need to get another review.
Attachment #8932346 - Flags: review?(tom) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1a69438ec05f fix build break with --disable-webrtc. r=tjr
Backed out alongside bug 1388219. Calling this wontfix under the assumption that you'll just fold this fix into bug 1388219 when it's ready to re-land. https://hg.mozilla.org/mozilla-central/rev/91fc3a79606b
You need to log in before you can comment on or make changes to this bug.