1421066 - getAppIniString in devtools/shared/system.js is slow

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Greg Tatum [:gregtatum]]

It hits the disk, and we're probably not even using that information. We should probably lazily instantiate it.

https://perfht.ml/2Abqc4o

I was on my home windows machine and noticed reaaaaally slow DevTools while installing some things in the background.

Comment 1

[Alexandre Poirot [:ochameau]]

As you said on irc, this does't seem to be used anywhere:
  https://searchfox.org/mozilla-central/search?q=changeset&case=true&regexp=false&path=devtools%2F

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1421066 - remove getAppIniString from devtools/shared/system.js;

getAppIniString was found to be slow, and the results were never used;
so remove it.

Review commit: https://reviewboard.mozilla.org/r/203572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203572/

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8932523 [details]
Bug 1421066 - remove getAppIniString from devtools/shared/system.js;

https://reviewboard.mozilla.org/r/203572/#review209024

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec355409f5e7
remove getAppIniString from devtools/shared/system.js; r=ochameau

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ec355409f5e7