Wait for the next event tick before resolving promise in places tests.

RESOLVED FIXED in Firefox 59

Status

()

Firefox
General
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: arai, Assigned: arai)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
There are several tests in browser/components/places/tests/ that fails after bug 1193394, because of promise resolution timing.
functions in browser/components/places/tests/browser/head.js needs to wait for the next event tick before resolving promise in event handler.
(Assignee)

Comment 1

2 months ago
Created attachment 8932838 [details] [diff] [review]
Wait for the next event tick before resolving promise in places tests.

promiseLibraryClosed and withSidebarTree should wait for the next event tick before resolving the promise inside unload/load event handler,
to avoid the remaining part of the testcase runs unexpectedly earlier,
after the change in bug 1193394.
Attachment #8932838 - Flags: review?(mak77)

Updated

2 months ago
Attachment #8932838 - Flags: review?(mak77) → review+

Comment 2

2 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efd54930bcdf
Wait for the next event tick before resolving promise in places tests. r=mak
(Assignee)

Comment 3

2 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/efd54930bcdf3e5c6996634f82c71f5abaea7009
Bug 1421115 - Wait for the next event tick before resolving promise in places tests. r=mak

Comment 4

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/efd54930bcdf
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.