Closed Bug 1421117 Opened 7 years ago Closed 7 years ago

Wait for the next event tick before resolving promise in browser_oneOffHeader.js.

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5800bb624450f22893e4918d653b3dbe231c4ac&selectedJob=147752924 > TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_oneOffHeader.js | Header has the correct index selected when a search engine has been selected - Got 0, expected 2 after fixing bug 1193394, the test needs to wait for the next event tick before resolving promise in mousemove event, to make sure everything gets ready.
synthesizeNativeMouseMove should wait for the next event tick before resolving the promise inside mousemove event handler, to avoid the remaining part of the testcase runs unexpectedly earlier, after the change in bug 1193394.
Attachment #8932840 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8932840 [details] [diff] [review] Wait for the next event tick before resolving promise in browser_oneOffHeader.js. Review of attachment 8932840 [details] [diff] [review]: ----------------------------------------------------------------- Florian would be a better reviewer here.
Attachment #8932840 - Flags: review?(gijskruitbosch+bugs) → review?(florian)
Attachment #8932840 - Flags: review?(florian) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5513671525ed Wait for the next event tick before resolving promise in browser_oneOffHeader.js. r=florian
https://hg.mozilla.org/integration/mozilla-inbound/rev/5513671525edd09ee5f1235087fd6ed7ca800cbe Bug 1421117 - Wait for the next event tick before resolving promise in browser_oneOffHeader.js. r=florian
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: