Wait for the next event tick before resolving promise in browser_oneOffHeader.js.

RESOLVED FIXED in Firefox 59

Status

()

Firefox
General
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: arai, Assigned: arai)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5800bb624450f22893e4918d653b3dbe231c4ac&selectedJob=147752924
> TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_oneOffHeader.js | Header has the correct index selected when a search engine has been selected - Got 0, expected 2

after fixing bug 1193394, the test needs to wait for the next event tick before resolving promise in mousemove event, to make sure everything gets ready.
(Assignee)

Comment 1

2 months ago
Created attachment 8932840 [details] [diff] [review]
Wait for the next event tick before resolving promise in browser_oneOffHeader.js.

synthesizeNativeMouseMove should wait for the next event tick before resolving the promise inside mousemove event handler,
to avoid the remaining part of the testcase runs unexpectedly earlier,
after the change in bug 1193394.
Attachment #8932840 - Flags: review?(gijskruitbosch+bugs)

Comment 2

2 months ago
Comment on attachment 8932840 [details] [diff] [review]
Wait for the next event tick before resolving promise in browser_oneOffHeader.js.

Review of attachment 8932840 [details] [diff] [review]:
-----------------------------------------------------------------

Florian would be a better reviewer here.
Attachment #8932840 - Flags: review?(gijskruitbosch+bugs) → review?(florian)
Attachment #8932840 - Flags: review?(florian) → review+

Comment 3

2 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5513671525ed
Wait for the next event tick before resolving promise in browser_oneOffHeader.js. r=florian
(Assignee)

Comment 4

2 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5513671525edd09ee5f1235087fd6ed7ca800cbe
Bug 1421117 - Wait for the next event tick before resolving promise in browser_oneOffHeader.js. r=florian

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5513671525ed
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.