1421302 - Personalization fixes for Pocket

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Christian Sadilek [:csadilek] (PTO until May, 30th)]

The following fixes are needed for personalized Pocket recommendations on NewTab:

- The disclaimer overlaps with the "Okay, got it" button on Windows
- Improve client-side rotation so that rotation is based on actual impressions, not just time
- Ensure domain affinity calculation isn't being executed too often
- Turn on personalization by default

Comment 1

[Ed Lee :Mardak]

Fixed in 59 as part of bug 1415812 export.
https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93

Comment 2

[Christian Sadilek [:csadilek] (PTO until May, 30th)]

Attachment: Bug 1421302 - Personalization fixes for Pocket

Review commit: https://reviewboard.mozilla.org/r/203580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203580/

Comment 3

[Ed Lee :Mardak]

Comment on attachment 8932529 [details]
Bug 1421302 - Personalization fixes for Pocket

https://reviewboard.mozilla.org/r/203580/#review209056

::: browser/extensions/activity-stream/install.rdf.in:11
(Diff revision 1)
>    <Description about="urn:mozilla:install-manifest">
>      <em:id>[e-mail]</em:id>
>      <em:type>2</em:type>
>      <em:bootstrap>true</em:bootstrap>
>      <em:unpack>false</em:unpack>
> -    <em:version>2017.11.03.1438-bf427ddd</em:version>
> +    <em:version>2017.11.24.1218-5d2dcaad</em:version>

Not sure how we want to handle this install.rdf.in dependency… The commit id will be different depending on how we end up rebasing things to the firefox-58 git branch.

Potentially either we rebase everything we want to that branch first or leave out this changed line. ?

Comment 4

[Christian Sadilek [:csadilek] (PTO until May, 30th)]

Comment on attachment 8932529 [details]
Bug 1421302 - Personalization fixes for Pocket

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203580/diff/1-2/

Comment 5

[Christian Sadilek [:csadilek] (PTO until May, 30th)]

Comment on attachment 8932529 [details]
Bug 1421302 - Personalization fixes for Pocket

Approval Request Comment
[Feature/Bug causing the regression]: 
User are seeing an incorrect Pocket disclaimer. On Windows, it doesn't render correctly and overlaps with the confirmation button. Further the disclaimer describes how Pocket recommendations are personalized, but they aren't as the feature isn't turned on in 58.

Once personalization is turned on, the current client-side rotation can cause Users to miss the most relevant stories.

[User impact if declined]:
- Users will expect personalized recommendations but will in fact see the global recommendations (same for all users)

- The disclaimer won't render correctly on Windows

[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes 20171119220126
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Pocket personalization is simply applying different client-side sorting to the global recommendations. The same content is fetched on all clients. In case of failing personalization, the default sort order (as present in the feed response) will be used.
[String changes made/needed]: No

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8932529 [details]
Bug 1421302 - Personalization fixes for Pocket

Fix a personalized Pocket recommendations on NewTab. Beta58+.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

What should be done regarding the conflict with the version number in install.rdf.in?

Comment 8

[Christian Sadilek [:csadilek] (PTO until May, 30th)]

:aryx The line (version number) has been removed in the latest revision. So, it should no longer cause a conflict.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2796c4cd23e3

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: [bug 1424292] Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3901