Personalization fixes for Pocket

RESOLVED FIXED in Firefox 58

Status

()

defect
--
major
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: csadilek, Assigned: csadilek)

Tracking

58 Branch
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed, firefox59 fixed)

Details

User Story

https://github.com/mozilla/activity-stream/compare/firefox-58b2...firefox-58b8

Attachments

(1 attachment, 1 obsolete attachment)

The following fixes are needed for personalized Pocket recommendations on NewTab:

- The disclaimer overlaps with the "Okay, got it" button on Windows
- Improve client-side rotation so that rotation is based on actual impressions, not just time
- Ensure domain affinity calculation isn't being executed too often
- Turn on personalization by default
Assignee

Updated

2 years ago
Target Milestone: --- → Firefox 58
Version: unspecified → 58 Branch

Comment 1

2 years ago
Fixed in 59 as part of bug 1415812 export.
https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93
Assignee: nobody → csadilek
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 58 → Firefox 59
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8932529 [details]
Bug 1421302 - Personalization fixes for Pocket

https://reviewboard.mozilla.org/r/203580/#review209056

::: browser/extensions/activity-stream/install.rdf.in:11
(Diff revision 1)
>    <Description about="urn:mozilla:install-manifest">
>      <em:id>activity-stream@mozilla.org</em:id>
>      <em:type>2</em:type>
>      <em:bootstrap>true</em:bootstrap>
>      <em:unpack>false</em:unpack>
> -    <em:version>2017.11.03.1438-bf427ddd</em:version>
> +    <em:version>2017.11.24.1218-5d2dcaad</em:version>

Not sure how we want to handle this install.rdf.in dependency… The commit id will be different depending on how we end up rebasing things to the firefox-58 git branch.

Potentially either we rebase everything we want to that branch first or leave out this changed line. ?
Attachment #8932529 - Flags: review?(edilee) → review+
Comment hidden (mozreview-request)
Assignee

Comment 5

2 years ago
Comment on attachment 8932529 [details]
Bug 1421302 - Personalization fixes for Pocket

Approval Request Comment
[Feature/Bug causing the regression]: 
User are seeing an incorrect Pocket disclaimer. On Windows, it doesn't render correctly and overlaps with the confirmation button. Further the disclaimer describes how Pocket recommendations are personalized, but they aren't as the feature isn't turned on in 58.

Once personalization is turned on, the current client-side rotation can cause Users to miss the most relevant stories.

[User impact if declined]:
- Users will expect personalized recommendations but will in fact see the global recommendations (same for all users)

- The disclaimer won't render correctly on Windows

[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes 20171119220126
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Pocket personalization is simply applying different client-side sorting to the global recommendations. The same content is fetched on all clients. In case of failing personalization, the default sort order (as present in the feed response) will be used.
[String changes made/needed]: No
Attachment #8932529 - Flags: approval-mozilla-beta?
Comment on attachment 8932529 [details]
Bug 1421302 - Personalization fixes for Pocket

Fix a personalized Pocket recommendations on NewTab. Beta58+.
Attachment #8932529 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
What should be done regarding the conflict with the version number in install.rdf.in?
Flags: needinfo?(csadilek)
Assignee

Comment 8

2 years ago
:aryx The line (version number) has been removed in the latest revision. So, it should no longer cause a conflict.
Assignee

Updated

2 years ago
Flags: needinfo?(csadilek)

Updated

2 years ago
User Story: (updated)

Updated

2 years ago
Attachment #8935814 - Attachment description: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3901 → [bug 1424292] Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3901
Attachment #8935814 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.