1421354 - Stub installer download doesn't resume if interrupted using NetLimiter

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Molly Howell (she/her) (no longer active)]

As reported in bug 798005 comment 16, the code added in that bug to resume downloads in the stub installer does not trigger if the download is interrupted using NetLimiter 4; instead the download restarts from the beginning in that case.

This is due to incomplete error handling in the bug 798005 patch. NetLimiter seems to trigger an error path in WinInet that other testing methods we've used do not.

Comment 1

[Molly Howell (she/her) (no longer active)]

This affects 58 and 59, but I don't think it merits beta uplift unless a more real-world scenario that triggers this bug is found.

Comment 2

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1421354 - Allow stub installer download resuming in more error cases.

Review commit: https://reviewboard.mozilla.org/r/203628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203628/

Comment 3

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8932571 [details]
Bug 1421354 - Allow stub installer download resuming in more error cases.

https://reviewboard.mozilla.org/r/203628/#review209084

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a482989240c9
Allow stub installer download resuming in more error cases. r=agashlin

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a482989240c9

Comment 6

[Oana Botisan, Desktop QA]

I tested the bug on Windows 10 x64 using the stub Installer for 59.0b6 and the bug is not reproducing anymore. I used the tool NetLimiter 4. 
I will mark this bug as verified fixed.