1421355 - Remove various unused methods from nsIXPConnect and nsXPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P3)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 1 - Remove nsIXPConnect::GetPrincipal().

This method is unused. It is the only caller of
XPCWrappedNative::GetObjectPrincipal() so remove that, too.

Review commit: https://reviewboard.mozilla.org/r/204036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204036/

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 2 - Remove nsIXPConnect::getWrappedNativeOfNativeObject.

This method is unused. It is the only caller of
XPCWrappedNative::GetUsedOnly(), so remove that, too.

Review commit: https://reviewboard.mozilla.org/r/204042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204042/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 3 - Remove nsIXPConnect::GarbageCollect().

Review commit: https://reviewboard.mozilla.org/r/204044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204044/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 4 - Remove nsXPConnect::GetInfoForName.

Review commit: https://reviewboard.mozilla.org/r/204046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204046/

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 5 - Remove nsXPConnect::NotifyDidPaint().

Presshell still does something along these lines, but it works completely differently.

Review commit: https://reviewboard.mozilla.org/r/204048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204048/

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 6 - Remove JS::NotifyDidPaint.

Review commit: https://reviewboard.mozilla.org/r/204050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204050/

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 7 - Remove unused defines and forward decls from nsIXPConnect.idl.

Review commit: https://reviewboard.mozilla.org/r/204052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204052/

Comment 8

[Andrew McCreight [:mccr8]]

Attachment: Bug 1421355, part 8 - Remove unused attributes and methods from nsIXPConnectWrappedNative.

Also remove some out of date comments. GetObjectPrincipal() was removed a while ago.

Review commit: https://reviewboard.mozilla.org/r/204054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204054/

Comment 9

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a00a6f275eec9040e86fc95116f6e35fb12aa5c6

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933070 [details]
Bug 1421355, part 1 - Remove nsIXPConnect::GetPrincipal().

https://reviewboard.mozilla.org/r/204036/#review209590

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933071 [details]
Bug 1421355, part 2 - Remove nsIXPConnect::getWrappedNativeOfNativeObject.

https://reviewboard.mozilla.org/r/204042/#review209592

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933072 [details]
Bug 1421355, part 3 - Remove nsIXPConnect::GarbageCollect().

https://reviewboard.mozilla.org/r/204044/#review209596

This was superceeded by nsIDOMWindowUtils.cycleCollect, right?

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933073 [details]
Bug 1421355, part 4 - Remove nsXPConnect::GetInfoForName.

https://reviewboard.mozilla.org/r/204046/#review209598

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933074 [details]
Bug 1421355, part 5 - Remove nsXPConnect::NotifyDidPaint().

https://reviewboard.mozilla.org/r/204048/#review209600

Comment 15

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933076 [details]
Bug 1421355, part 7 - Remove unused defines and forward decls from nsIXPConnect.idl.

https://reviewboard.mozilla.org/r/204052/#review209602

Comment 16

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933077 [details]
Bug 1421355, part 8 - Remove unused attributes and methods from nsIXPConnectWrappedNative.

https://reviewboard.mozilla.org/r/204054/#review209604

Comment 17

[Andrew McCreight [:mccr8]]

(In reply to Blake Kaplan (:mrbkap) from comment #12)
> This was superceeded by nsIDOMWindowUtils.cycleCollect, right?

It looks like this particular method was used from C++ to trigger a GC, called in nsJSContext::GarbageCollectNow(). That code now directly calls JS APIs to trigger GC. Presumably somebody got sick of having to thread everything through XPConnect at some point.

Comment 18

[Jon Coppeard (:jonco)]

Comment on attachment 8933075 [details]
Bug 1421355, part 6 - Remove JS::NotifyDidPaint.

https://reviewboard.mozilla.org/r/204050/#review209714

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e6d4aebb308
part 1 - Remove nsIXPConnect::GetPrincipal(). r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/6c69d8543e1f
part 2 - Remove nsIXPConnect::getWrappedNativeOfNativeObject. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/017bffb7993c
part 3 - Remove nsIXPConnect::GarbageCollect(). r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/b539213159c8
part 4 - Remove nsXPConnect::GetInfoForName. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/771c24107123
part 5 - Remove nsXPConnect::NotifyDidPaint(). r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/0b00ae699a2d
part 6 - Remove JS::NotifyDidPaint. r=jonco
https://hg.mozilla.org/integration/autoland/rev/dff3895c06ba
part 7 - Remove unused defines and forward decls from nsIXPConnect.idl. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/e2c51c4947a7
part 8 - Remove unused attributes and methods from nsIXPConnectWrappedNative. r=mrbkap

Comment 20

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2e6d4aebb308
https://hg.mozilla.org/mozilla-central/rev/6c69d8543e1f
https://hg.mozilla.org/mozilla-central/rev/017bffb7993c
https://hg.mozilla.org/mozilla-central/rev/b539213159c8
https://hg.mozilla.org/mozilla-central/rev/771c24107123
https://hg.mozilla.org/mozilla-central/rev/0b00ae699a2d
https://hg.mozilla.org/mozilla-central/rev/dff3895c06ba
https://hg.mozilla.org/mozilla-central/rev/e2c51c4947a7