Closed
Bug 1421389
Opened 7 years ago
Closed 7 years ago
Update dark theme with lower-contrast sidebars
Categories
(DevTools :: General, defect, P3)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: victoria, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The following changes should be made to the dark theme. This is a more refined look that makes all the sidebars subtler-looking, which was especially important for the Debugger.
#909090 sidebar/accordion text
#58575c line numbers
#1B1B1D sidebar backgrounds, source header, source outline unselected tab, line number gutter, etc.
#222225 accordion header
Should look like the second example in this image: https://pbs.twimg.com/media/DPLwSvDVQAA03Bi.jpg:large
CC: :gl
Reporter | ||
Updated•7 years ago
|
Blocks: devtools-visual
Assignee | ||
Updated•7 years ago
|
Priority: -- → P3
Reporter | ||
Comment 1•7 years ago
|
||
It occurred to me that the sidebars in Inspector (and most panels) are much more important than they are in Debugger, and this will make it a bit hard to read crucial pieces like CSS rule names.
Could we keep the main body text in all non-Debugger panels the same as they currently are (#B1B1B3) and just tone it down to #909090 for the Debugger? New background colors for all panels is fine.
Reporter | ||
Comment 2•7 years ago
|
||
Just poking this issue :). Any chance of movement on this?
Flags: needinfo?(gl)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(gl)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8943882 [details]
Bug 1421389 - Update dark theme with lower-contrast sidebars.
https://reviewboard.mozilla.org/r/214228/#review219956
Attachment #8943882 -
Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1e6c367f91c
Update dark theme with lower-contrast sidebars. r=pbro
Comment 6•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•