Update dark theme with lower-contrast sidebars

RESOLVED FIXED in Firefox 59

Status

()

Firefox
Developer Tools
P3
normal
RESOLVED FIXED
2 months ago
2 days ago

People

(Reporter: victoria, Assigned: gl)

Tracking

(Blocks: 1 bug)

58 Branch
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 months ago
The following changes should be made to the dark theme. This is a more refined look that makes all the sidebars subtler-looking, which was especially important for the Debugger.

#909090 sidebar/accordion text
#58575c line numbers
#1B1B1D sidebar backgrounds, source header, source outline unselected tab, line number gutter, etc.
#222225 accordion header

Should look like the second example in this image: https://pbs.twimg.com/media/DPLwSvDVQAA03Bi.jpg:large
CC: :gl
(Reporter)

Updated

2 months ago
Blocks: 1389730
(Assignee)

Updated

2 months ago
Priority: -- → P3
(Reporter)

Comment 1

2 months ago
It occurred to me that the sidebars in Inspector (and most panels) are much more important than they are in Debugger, and this will make it a bit hard to read crucial pieces like CSS rule names.

Could we keep the main body text in all non-Debugger panels the same as they currently are (#B1B1B3) and just tone it down to #909090 for the Debugger? New background colors for all panels is fine.
(Reporter)

Comment 2

a month ago
Just poking this issue :). Any chance of movement on this?
Flags: needinfo?(gl)
(Assignee)

Updated

3 days ago
Flags: needinfo?(gl)
(Assignee)

Updated

3 days ago
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 4

3 days ago
mozreview-review
Comment on attachment 8943882 [details]
Bug 1421389 - Update dark theme with lower-contrast sidebars.

https://reviewboard.mozilla.org/r/214228/#review219956
Attachment #8943882 - Flags: review?(pbrosset) → review+

Comment 5

3 days ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1e6c367f91c
Update dark theme with lower-contrast sidebars. r=pbro

Comment 6

2 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a1e6c367f91c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.