Closed Bug 1421444 Opened 3 years ago Closed 3 years ago

Fix sass linting

Categories

(Firefox :: New Tab Page, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 59
Iteration:
1.25
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: Mardak, Assigned: sean, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

No description provided.
:Mardak more recently updated this into https://github.com/mozilla/activity-stream/pull/3871, which is currently marked as blocked in github (for unclear reasons) and has a few conflicts.  My recollection of our Monday meeting was that it needs to be fixed up to catch a few more errors and then can be reviewed.  Or is there some additional reason it was blocked?
Flags: needinfo?(edilee)
It was rebased on top of a sass-lint update, which hasn't been merged yet.
Flags: needinfo?(edilee)
I'd like to continue off where we left off from the issue on GitHub - please let me know where I may begin again!
Assignee: dmose → S.Prashad
Mentor: dmose
Whiteboard: [assigned to contributor]
Attachment #8933030 - Attachment is obsolete: true
Sean, I've already updated your PR/commits on top of the latest master, so unless there are review comments to address, it should be good to go! Thanks for your work in getting all of this done. :)
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/6c92c7c8601acf7493946d34c92fa497cb764b3c
fix(styles): Enable sass-lint and fix errors
Fix Bug 1421444 - Fix sass linting
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Blocks: 1421917
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.