Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Mardak, Assigned: sean, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 59
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox58 wontfix, firefox59 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Updated

a year ago
status-firefox58: --- → wontfix
:Mardak more recently updated this into https://github.com/mozilla/activity-stream/pull/3871, which is currently marked as blocked in github (for unclear reasons) and has a few conflicts.  My recollection of our Monday meeting was that it needs to be fixed up to catch a few more errors and then can be reviewed.  Or is there some additional reason it was blocked?
Flags: needinfo?(edilee)
(Reporter)

Comment 2

a year ago
It was rebased on top of a sass-lint update, which hasn't been merged yet.
Flags: needinfo?(edilee)
(Assignee)

Comment 3

a year ago
I'd like to continue off where we left off from the issue on GitHub - please let me know where I may begin again!
(Reporter)

Updated

a year ago
Assignee: dmose → S.Prashad
Mentor: dmose
Whiteboard: [assigned to contributor]
(Reporter)

Updated

a year ago
Attachment #8933030 - Attachment is obsolete: true
(Reporter)

Comment 6

a year ago
Sean, I've already updated your PR/commits on top of the latest master, so unless there are review comments to address, it should be good to go! Thanks for your work in getting all of this done. :)

Comment 7

a year ago
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/6c92c7c8601acf7493946d34c92fa497cb764b3c
fix(styles): Enable sass-lint and fix errors
Fix Bug 1421444 - Fix sass linting

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Reporter)

Updated

a year ago
Blocks: 1421917
(Reporter)

Comment 8

a year ago
https://hg.mozilla.org/mozilla-central/rev/ea7f2137961f
status-firefox59: affected → fixed
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.