1421458 - Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement, P2)

Description

[Mark Banner (:standard8)]

As part of spreading ESLint further throughout the tree, I want to do some setup to make things easier for mentored bugs.

I'm focussing on xpcshell-test directories for now, as they are the easier ones, and I'm pondering an improvement for html files that might make it easier to determine globals.

This patch basically comes down to two things:

- Add more .eslintrc.js files for xpcshell test related directories (they will still be disabled, until follow-up bugs).

- Change some of .eslintignore to not blanket-out top-level directories, but list some of the sub-directories that we want to ignore.

This way, most of the bugs will be "remove the line from .eslintignore, fix the issues raised".

It also helps me knowing how many issues in each directory, so I can split bugs appropriately.

Comment 1

[Mark Banner (:standard8)]

Note, this isn't all xpcshell test related directories, as some of them have parents with test files in, which makes .eslintignore quite hard to manage. Hence, I'm doing the more "simple" ones here.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1421458 - Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories.

Review commit: https://reviewboard.mozilla.org/r/203696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203696/

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8932639 [details]
Bug 1421458 - Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203696/diff/1-2/

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8932639 [details]
Bug 1421458 - Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories.

https://reviewboard.mozilla.org/r/203696/#review209184

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88b37f04fdd6
Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories. r=mossop

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/88b37f04fdd6