Closed Bug 1421458 Opened 2 years ago Closed 2 years ago

Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories

Categories

(Firefox Build System :: Lint and Formatting, enhancement, P2)

3 Branch
enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of spreading ESLint further throughout the tree, I want to do some setup to make things easier for mentored bugs.

I'm focussing on xpcshell-test directories for now, as they are the easier ones, and I'm pondering an improvement for html files that might make it easier to determine globals.

This patch basically comes down to two things:

- Add more .eslintrc.js files for xpcshell test related directories (they will still be disabled, until follow-up bugs).

- Change some of .eslintignore to not blanket-out top-level directories, but list some of the sub-directories that we want to ignore.

This way, most of the bugs will be "remove the line from .eslintignore, fix the issues raised".

It also helps me knowing how many issues in each directory, so I can split bugs appropriately.
Note, this isn't all xpcshell test related directories, as some of them have parents with test files in, which makes .eslintignore quite hard to manage. Hence, I'm doing the more "simple" ones here.
Comment on attachment 8932639 [details]
Bug 1421458 - Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories.

https://reviewboard.mozilla.org/r/203696/#review209184
Attachment #8932639 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88b37f04fdd6
Add more initial configuration setup and prepare .eslintignore for enabling ESLint on more xpcshell-test directories. r=mossop
https://hg.mozilla.org/mozilla-central/rev/88b37f04fdd6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.