1421464 - Advance history engine's lastSync timestamp as we add visits to places

Status: NEW

(Firefox :: Sync, enhancement, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

In bug 1416788 we decided to "chunk" the calls made to places to insert history as specifying too many visits in one call has bad consequences. We should upgrade that so it (a) sorts the records by the last modified timestamp, and (b) advances the lastSync timestamp of the engine as we go. This will mean that if sync is interrupted it has more chance of not reapplying those same records each time.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Currently, updating lastSync requires us fetch all the items we need to backfill. Failing to do this would mean we never backfill these items.

This is costly, but the best/only plan we have to reduce the cost of it is bug 1435007, so I don't think we should do this without that one (nor can we, really).

In the mean time we have a P3 blocking a P2 which seems wrong... but oh well.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

This is P3 since we have a P3 blocking it.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 4

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.