1421473 - Update to ESLint 4 "indent" rule

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #1421459 +++

This also requires fixing all of the broken indentation the legacy indent rule allowed (or sometimes required).

I'm just going to use --fix for this one...

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1421473: Update to the ESLint 4 "indent" rule.

Review commit: https://reviewboard.mozilla.org/r/203720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203720/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8932664 [details]
Bug 1421473: Update to the ESLint 4 "indent" rule.

https://reviewboard.mozilla.org/r/203720/#review209508

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5067390af63cab48cc3f9bc688f662b6b4035504
Bug 1421473: Update to the ESLint 4 "indent" rule. r=aswan

Comment 4

[Raul Gurzau (:RaulG)]

Backed out changeset 5067390af63c (bug 1421473) for merge conflict r=backout

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/2808954b03186f20b2c7fa1eb9d90f67bbd058c0

Push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5067390af63cab48cc3f9bc688f662b6b4035504

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d7e64b676fe7f911c77db89e2b243374769ef9c
Bug 1421473: Update to the ESLint 4 "indent" rule. r=aswan

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff09ce6d8883
Backed out changeset 3d7e64b676fe for TV failures /test/mochitest/test_bug687194.html on a CLOSED TREE

Comment 7

[Raul Gurzau (:RaulG)]

Backed out changeset 3d7e64b676fe for TV failures /test/mochitest/test_bug687194.html on a CLOSED TREE

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff09ce6d88831fb6498a8d8212d92ed3bc562d2f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3d7e64b676fe7f911c77db89e2b243374769ef9c

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=150951784&repo=mozilla-inbound&lineNumber=2059

INFO -  5 INFO TEST-PASS | toolkit/mozapps/extensions/test/mochitest/test_bug687194.html | URI shouldn't resolve to begin with
00:43:43     INFO -  Buffered messages finished
00:43:43    ERROR -  6 INFO TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/mochitest/test_bug687194.html | Test timed out.
00:43:43     INFO -      reportError@SimpleTest/TestRunner.js:121:7

Comment 8

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 9

[Mark Banner (:standard8)]

Given that we've long since switched to prettier, this seems to now be wontfix.