1421563 - Remove unused function declaration

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P3)

Description

[Kevin Chen[:kechen] (UTC + 8)]

The implementation of TryOptimizeToImageLayer[1] is removed in Bug 1163878, but  the declaration is left in the codebase.

I think we can remove it.

[1] https://searchfox.org/mozilla-central/rev/9f3bd430c2b132c86c46126a0548661de876799a/layout/painting/nsDisplayList.h#3789

Comment 1

[Aleksandr]

Hello, I'd like to work on this bug as my good-first-bug!

Comment 2

[A. W. Lasher[:alasher] (UTC - 4)]

Attachment: Bug 1421563 - Remove TryOptimizeToImageLayer declaration;

TryOptimizeToImageLayer was renamed/repurposed in c0654f3b986d, but
the old declaration was never removed.

Review commit: https://reviewboard.mozilla.org/r/221852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221852/

Comment 3

[A. W. Lasher[:alasher] (UTC - 4)]

https://reviewboard.mozilla.org/r/221852/diff/1#index_header

Sorry to take this first-bug from you Aleksandr. For your reference, I followed the guide here to get set up with Mercurial/MozReview: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview.html

Comment 4

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8952612 [details]
Bug 1421563 - Remove TryOptimizeToImageLayer declaration;

https://reviewboard.mozilla.org/r/221852/#review229796

Comment 5

[Noemi Erli[:noemi_erli]]

We need the r+ on the left side of the review board else we cannot land it.

Comment 6

[A. W. Lasher[:alasher] (UTC - 4)]

Comment on attachment 8952612 [details]
Bug 1421563 - Remove TryOptimizeToImageLayer declaration;

https://reviewboard.mozilla.org/r/221852/#review229866

Comment 7

[Kevin Chen[:kechen] (UTC + 8)]

Hello Matt,
I don't have the authorization to review this patch, could you help me to do it?

Comment 8

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8952612 [details]
Bug 1421563 - Remove TryOptimizeToImageLayer declaration;

https://reviewboard.mozilla.org/r/221852/#review231204

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61c9f8520dc8
Remove TryOptimizeToImageLayer declaration; r=kechen,mattwoodrow

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/61c9f8520dc8

Comment 11

[A. W. Lasher[:alasher] (UTC - 4)]

Thanks everyone!