1421641 - After you use the "Clear Form" button on a credit card field form, the form becomes unresponsive

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect)

Description

[ovidiu boca[:Ovidiu]]

Affected versions]:

Tested on Nightly 59.0a1(2017-11-29)

[Affected platforms]:

Tested on Mac OS X 10.13, Windows 10

[Steps to reproduce]:

Prerequisites:

 Make sure you have at least two saved credit cards.
 
 STR:

1. Navigate to Amazon.com and login with a valid account.
2. From the right corner hover Account &Lists and select account
3. Select "Payment Options"
4. Double click on "Name on card" field and select a credit card from the drop-down.
5. Click again on "Name on card" or "Card number" fields
6. Click on "Clear Form"
7. Click again on "Name on card" or "Card number" fields




[Expected result]:

A drop down with your credit cards is shown

[Actual result]:

Nothing happens. 

Note: Even if I change the focus of the field the drop down doesn't work.

Comment 1

[Luke Chang [:lchang] (inactive)]

Ray, could you take a look? Thanks.

Comment 2

[Ray Lin[:ralin]]

Sure, I first suspect it might related to event listener conflict with Amazon, and we should handle in another path like mozSystemGroup to get rid of any interference from client. I'll see more to that. Thanks.

Comment 3

[Ray Lin[:ralin]]

will attach a patch in minutes :D

Comment 4

[Ray Lin[:ralin]]

Attachment: Bug 1421641 - Handle event listeners in mozSystemGroup and do full field states reset when clearing populated form.

Review commit: https://reviewboard.mozilla.org/r/204166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204166/

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8933223 [details]
Bug 1421641 - Handle event listeners in mozSystemGroup and do full field states reset when clearing populated form.

https://reviewboard.mozilla.org/r/204166/#review210242

Looks good.

Comment 6

[Ray Lin[:ralin]]

Thanks for review :D, since bug 1415073 is landing, I'll rebase the patch on top of it in case conflict.

Comment 7

[Ray Lin[:ralin]]

Comment on attachment 8933223 [details]
Bug 1421641 - Handle event listeners in mozSystemGroup and do full field states reset when clearing populated form.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204166/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4e6ca9ed4da
Handle event listeners in mozSystemGroup and do full field states reset when clearing populated form. r=lchang

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d4e6ca9ed4da

Comment 10

[ovidiu boca[:Ovidiu]]

I verified this issue on Mac OS X 10.13, 10.11, Windows 10,7 and Ubuntu 16.04 and we can't reproduce it. I will mark it as verified fixed.