Remove docshell markers
Categories
(Core :: Gecko Profiler, enhancement, P3)
Tracking
()
People
(Reporter: gregtatum, Assigned: aabh)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxp])
Attachments
(3 files, 7 obsolete files)
The docshell markers need to be removed after we've migrated to the new performance recording panel. This is the bug to track that work.
Reporter | ||
Updated•7 years ago
|
Comment 1•6 years ago
|
||
Greg, can you add some background about why we want to do this?
Reporter | ||
Comment 2•6 years ago
|
||
docshell markers are collected via references to the docshell. This is really nice because it's easy to associate a given event with a particular website. The DevTools performance tool uses these, and created a competing implementation with the Gecko Profiler markers. It would be nice to unify these approaches and only have one implementation of markers. https://searchfox.org/mozilla-central/source/docshell/base/timeline We might need to have a broader conversation to figure out exactly how to accomplish this, as the docshell markers are nice in that they can be targeted at one particular docshell, while the Gecko Profiler ones are associated per content process. It would be nice to do some investigation on figuring out how to get some kind of docshell ID in the marker payloads of the Gecko Profiles. See bug 1417976.
Updated•6 years ago
|
Comment 4•2 years ago
•
|
||
The Firefox Profiler markers now have information about the content they relate to. I believe we can remove docshell markers now as I don't think there's any consumer left.
Of course it would be good while doing that that we also have existing equivalent Firefox Profiler markers.
Updated•2 years ago
|
Assignee | ||
Updated•9 months ago
|
Assignee | ||
Comment 5•9 months ago
|
||
This patch removes the old docshell timeline AutoTimelineMarker from the codebase and replaces it with an equivalent Gecko profiler marker. This patch also fixes Bug 1834143, which is a subset of 1421651.
Assignee | ||
Comment 6•9 months ago
|
||
Depends on D184217
Assignee | ||
Comment 7•9 months ago
|
||
Depends on D185176
Assignee | ||
Comment 8•9 months ago
|
||
Depends on D185177
Assignee | ||
Comment 9•9 months ago
|
||
Depends on D185178
Assignee | ||
Comment 10•9 months ago
|
||
Depends on D185179
Assignee | ||
Comment 11•9 months ago
|
||
Depends on D185180
Assignee | ||
Comment 12•9 months ago
|
||
Depends on D185181
Updated•9 months ago
|
Updated•9 months ago
|
Updated•9 months ago
|
Updated•9 months ago
|
Updated•9 months ago
|
Updated•9 months ago
|
Updated•9 months ago
|
Updated•9 months ago
|
Updated•8 months ago
|
Updated•8 months ago
|
Updated•8 months ago
|
Assignee | ||
Comment 13•8 months ago
|
||
This patch adds an API to count the number of restyles triggered by animations. This API will replace the existing timeline marker based testing of the animation/restyle system.
Assignee | ||
Comment 14•8 months ago
|
||
This commits integrates the new animation triggered restyle counter into the existing tests to ensure that the counter matches the expected marker count.
Depends on D186714
Comment 15•8 months ago
|
||
Pushed by abrouwersharries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac079a84284e Add counter API for animation triggered restyles r=emilio
Comment 16•8 months ago
|
||
Pushed by abrouwersharries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/073e03319881 Integrate animation triggered restyle counter into tests r=emilio
Comment 17•8 months ago
|
||
bugherder |
Comment 18•8 months ago
|
||
Backed out changeset 073e03319881 (Bug 1421651) for causing bc failures at browser_test_group_fission.js
Backout: https://hg.mozilla.org/integration/autoland/rev/235e5f8367c37949a2d89de23db0c1f375b8a897
Failure log: https://treeherder.mozilla.org/logviewer?job_id=427048374&repo=autoland&lineNumber=3601
Comment 19•8 months ago
|
||
Pushed by abrouwersharries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f98030e536f Integrate animation triggered restyle counter into tests r=emilio
Comment 20•8 months ago
|
||
bugherder |
Assignee | ||
Comment 21•8 months ago
|
||
The above commit only adds the facilities required to enable removal, unfortunately. Re-opening while waiting for D184217, which will definitively close this.
Updated•8 months ago
|
Comment 22•6 months ago
|
||
Pushed by abrouwersharries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/714aaf6484fb Remove obseleted timeline and TimelineMarker code r=canaltinova,webidl,devtools-reviewers,saschanaz,smaug,ochameau
Comment 23•6 months ago
|
||
bugherder |
Updated•6 months ago
|
Comment 24•6 months ago
|
||
Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.
Comment 25•6 months ago
|
||
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b9fbacd9ede Backed out changeset 714aaf6484fb for causing Bug 1860719. CLOSED TREE
Comment 26•6 months ago
|
||
Backed out for causing Bug 1860719
Backout link: https://hg.mozilla.org/integration/autoland/rev/0b9fbacd9ede37c7251df859c9578a695c054a8f
Log link: https://treeherder.mozilla.org/logviewer?job_id=433586895&repo=autoland&lineNumber=84169
Comment 27•6 months ago
|
||
Pushed by abrouwersharries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02f729ed8438 Remove obseleted timeline and TimelineMarker code r=canaltinova,webidl,devtools-reviewers,saschanaz,smaug,ochameau
Updated•6 months ago
|
Comment 28•6 months ago
|
||
bugherder |
Updated•6 months ago
|
Assignee | ||
Updated•6 months ago
|
Description
•