1421651 - Remove docshell markers

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Greg Tatum [:gregtatum] (REO Fx132)]

The docshell markers need to be removed after we've migrated to the new performance recording panel. This is the bug to track that work.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Greg, can you add some background about why we want to do this?

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

docshell markers are collected via references to the docshell. This is really nice because it's easy to associate a given event with a particular website. The DevTools performance tool uses these, and created a competing implementation with the Gecko Profiler markers. It would be nice to unify these approaches and only have one implementation of markers.

https://searchfox.org/mozilla-central/source/docshell/base/timeline

We might need to have a broader conversation to figure out exactly how to accomplish this, as the docshell markers are nice in that they can be targeted at one particular docshell, while the Gecko Profiler ones are associated per content process. It would be nice to do some investigation on figuring out how to get some kind of docshell ID in the marker payloads of the Gecko Profiles. See bug 1417976.

Comment 4

[Julien Wajsberg [:julienw]]

The Firefox Profiler markers now have information about the content they relate to. I believe we can remove docshell markers now as I don't think there's any consumer left.

Of course it would be good while doing that that we also have existing equivalent Firefox Profiler markers.

Comment 5

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove obseleted timeline and TimelineMarker code r=canaltinova

This patch removes the old docshell timeline AutoTimelineMarker from the codebase and replaces it with an equivalent Gecko profiler marker. This patch also fixes Bug 1834143, which is a subset of 1421651.

Comment 6

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove WorkerTimelineMarker r=canaltinova

Depends on D184217

Comment 7

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove TimestampTimelineMarker r=canaltinova

Depends on D185176

Comment 8

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove ConsoleTimelineMarker r=canaltinova

Depends on D185177

Comment 9

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove DocLoadingTimelineMarker r=canaltinova

Depends on D185178

Comment 10

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove EventTimelineMarker r=canaltinova

Depends on D185179

Comment 11

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove JavascriptTimelineMarker r=canaltinova

Depends on D185180

Comment 12

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Remove remaining timeline marker code r=canaltinova

Depends on D185181

Comment 13

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Add counter API for animation triggered restyles r?emilio

This patch adds an API to count the number of restyles triggered by animations. This API will replace the existing timeline marker based testing of the animation/restyle system.

Comment 14

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1421651 - Integrate animation triggered restyle counter into tests r?emilio

This commits integrates the new animation triggered restyle counter into the existing tests to ensure that the counter matches the expected marker count.

Depends on D186714

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac079a84284e
Add counter API for animation triggered restyles r=emilio

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/073e03319881
Integrate animation triggered restyle counter into tests r=emilio

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ac079a84284e

Comment 18

[Cristina Horotan [:chorotan]]

Backed out changeset 073e03319881 (Bug 1421651) for causing bc failures at browser_test_group_fission.js

Backout: https://hg.mozilla.org/integration/autoland/rev/235e5f8367c37949a2d89de23db0c1f375b8a897

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=073e03319881f9142f37c51667ddec73b8c335a5

Failure log: https://treeherder.mozilla.org/logviewer?job_id=427048374&repo=autoland&lineNumber=3601

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f98030e536f
Integrate animation triggered restyle counter into tests r=emilio

Comment 20

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1f98030e536f

Comment 21

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

The above commit only adds the facilities required to enable removal, unfortunately. Re-opening while waiting for D184217, which will definitively close this.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/714aaf6484fb
Remove obseleted timeline and TimelineMarker code r=canaltinova,webidl,devtools-reviewers,saschanaz,smaug,ochameau

Comment 23

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/714aaf6484fb

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 25

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b9fbacd9ede
Backed out changeset 714aaf6484fb for causing Bug 1860719. CLOSED TREE

Comment 26

[Narcis Beleuzu [:NarcisB]]

Backed out for causing Bug 1860719

Backout link: https://hg.mozilla.org/integration/autoland/rev/0b9fbacd9ede37c7251df859c9578a695c054a8f
Log link: https://treeherder.mozilla.org/logviewer?job_id=433586895&repo=autoland&lineNumber=84169

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02f729ed8438
Remove obseleted timeline and TimelineMarker code r=canaltinova,webidl,devtools-reviewers,saschanaz,smaug,ochameau

Comment 28

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/02f729ed8438