Open Bug 1421651 Opened 4 years ago Updated 4 years ago

Remove docshell markers

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: gregtatum, Unassigned)

References

(Blocks 2 open bugs)

Details

The docshell markers need to be removed after we've migrated to the new performance recording panel. This is the bug to track that work.
Priority: -- → P3
Blocks: 1278588
Greg, can you add some background about why we want to do this?
Flags: needinfo?(gtatum)
docshell markers are collected via references to the docshell. This is really nice because it's easy to associate a given event with a particular website. The DevTools performance tool uses these, and created a competing implementation with the Gecko Profiler markers. It would be nice to unify these approaches and only have one implementation of markers.

https://searchfox.org/mozilla-central/source/docshell/base/timeline

We might need to have a broader conversation to figure out exactly how to accomplish this, as the docshell markers are nice in that they can be targeted at one particular docshell, while the Gecko Profiler ones are associated per content process. It would be nice to do some investigation on figuring out how to get some kind of docshell ID in the marker payloads of the Gecko Profiles. See bug 1417976.
Depends on: 1417976
Flags: needinfo?(gtatum)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.