1421682 - Activity Streams exhausts file descriptors capturing screenshots when large numbers of bookmarks are added at once

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Morikko]

Attachment: tab_dead.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171113102034

Steps to reproduce:

In my extension Sync Tab Groups, I am saving lots of tabs as bookmarks at once.
* Firefox 57
* Fedora 26

https://github.com/Morikko/sync-tab-groups/blob/master/background/storage/bookmarkstorage.js 
My code do (once each 30s at most):
 - find the root folder or create it
 - clean previous save if has
 - save each groups of tabs in a subfolder



Actual results:

Not at each backup, but sometimes those errors are visible in the console:

[[This error many times]]
Error: Could not establish connection. Receiving end does not exist.  undefined
Un arbre non équilibré a été écrit en utilisant « document.write() » provoquant une nouvelle analyse de données provenant du réseau. Pour plus d’informations, consultez https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing  home.htm:32 
 
Error: Could not establish connection. Receiving end does not exist.  undefined
getScreenshot error: Unix error 24 during operation open on file /home/eric/.cache/mozilla/firefox/i6xygatd.default/thumbnails/a7dcc5d79743851d4f92d54db1f15ad9.png (Too many open files) Screenshots.jsm:61
	getScreenshotForURL resource://activity-stream/lib/Screenshots.jsm:61:7
	throw self-hosted:1207:9

StorageManager.Bookmark.saveGroups failed: Error: no item found for the given GUID  bookmarkstorage.js:81:5
	StorageManager.Bookmark.saveGroups moz-extension://64b6e8a9-f585-49ff-b5e0-343e07d43870/background/bookmarkstorage.js:81:5

getScreenshot error: Error: page-thumbnail:error Screenshots.jsm:61
	getScreenshotForURL resource://activity-stream/lib/Screenshots.jsm:61:7
	throw self-hosted:1207:9

	update.locale file doesn't exist in either the application or GRE directories  UpdateUtils.jsm:125
		getLocale resource://gre/modules/UpdateUtils.jsm:125:5
		throw self-hosted:1207:9

On top of that, when it happens Firefox is no more usable. All tabs content are like in the attached file: a wheel is turning and it is impossible to have any content. Same for new tabs.
I have to restart Firefox.


Expected results:

Bookmarks are saved correctly or an error is raised but that doesn't break Firefox.

Additional details:
https://github.com/Morikko/sync-tab-groups/issues/14#issuecomment-345548703
An user had the problems and also saw lots of errors in Screenshots.jsm

https://github.com/Morikko/sync-tab-groups/issues/20
Another user with this problem on ArchLinux.

Comment 1

[Tim Spurway [:tspurway]]

We should only bookmark a maximum of 9 bookmarks on any mass bookmarking event

Comment 2

[Ed Lee :Mardak]

I would assume tspurway ment "should only screenshot a max of 9…"

Comment 3

[Tim Spurway [:tspurway]]

yes.  screenshot.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e1b76607316711ff9cca859183171ce1a7900b9a
Fix Bug 1421682 - Activity Streams exhausts file descriptors capturing screenshots when large numbers of bookmarks are added at once

https://github.com/mozilla/activity-stream/commit/9610270efc10bf4158f9e1d88d96db7f7baacfe6
Merge pull request #4059 from sarracini/bug_1421682

 Fix Bug 1421682 - Activity Streams exhausts file descriptors capturing screenshots when large numbers of bookmarks are added at once

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5dc20e8d5f71