Closed
Bug 1421685
Opened 7 years ago
Closed 7 years ago
Fix references to "scope chain" in BaselineCompiler
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: tcampbell, Assigned: mgaudet)
Details
Attachments
(1 file)
|
2.32 KB,
patch
|
tcampbell
:
review+
|
Details | Diff | Splinter Review |
In Bug 1263355, the frontend had a large rewrite and terminology was cleaned up. There are some comments in BaselineCompiler.cpp that use old terms. In particular, "environment chain" is the dynamic chain used during execuion, and "scope chain" is information built during parse. If you search for "scope chain" in BaselineCompiler.cpp, most of those comments are out of date.
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → mgaudet
Priority: -- → P3
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8932977 -
Flags: review?(tcampbell)
|
|
Reporter | |
Comment 2•7 years ago
|
||
Comment on attachment 8932977 [details] [diff] [review] Fix comments in BaselineCompiler.cpp Review of attachment 8932977 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks for fixing these.
Attachment #8932977 -
Flags: review?(tcampbell) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b836b187359 Correct scope chain reference in Baseline. r=tcampbell
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6b836b187359
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•